chore(core): kmc --outFile to kmc --out-file (and -- rider) 🙀#7311
Merged
mcdurdin merged 5 commits intofeature-ldmlfrom Sep 20, 2022
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
approved these changes
Sep 19, 2022
Contributor
ermshiperete
left a comment
There was a problem hiding this comment.
lgtm - although I don't particularly like putting these extra parameters in a --configure parameter. But that's a different thing...
srl295
approved these changes
Sep 19, 2022
Allows use of `./build.sh configure -- --param-one=foo ...`. Updates Core build to support `--` (including build.bat wrapper for Windows builds). Fixes Linux debian rules to pass additional parameters in with this format again, and adds `:arch` to only build current architecture, not wasm as well... Note that when using `--` you should typically avoid multiple actions in a single command, as each action may interpret the additional parameters differently!
kmc --outFile to kmc --out-file (and -- rider) 🙀
Member
Author
And it wasn't working anyway so fixed to use |
| "--target-path=opt_target_path Override for build/ target path" \ | ||
| "--configure=opt_configure Options to pass to C++ configure" \ | ||
| "--test=opt_tests,-t Test[s] to run (space separated)" | ||
| "--debug,d configuration is 'debug', not 'release'" \ |
Contributor
There was a problem hiding this comment.
Nothing new, but that should have been: --debug,-d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the failing Core tests in #7054 -- broke in #7286, but wasn't picked up
there because Core build didn't run on that PR.
All about
./build.sh --This update also allows use of
./build.sh configure -- --param-one=foo ....Updates Core build to support
--(including build.bat wrapper for Windows builds). Fixes Linux debian rules to pass additional parameters in with this format again, and adds:archto only build current architecture, not wasm as well...Note that when using
--you should typically avoid multiple actions in a single command, as each action may interpret the additional parameters differently!@keymanapp-test-bot skip