Skip to content

chore(common): add KF_KMXPLUS dwFlag value 🙀#7050

Merged
mcdurdin merged 1 commit intofeature-ldmlfrom
chore/common/7045-kmxplus-header-flag
Aug 8, 2022
Merged

chore(common): add KF_KMXPLUS dwFlag value 🙀#7050
mcdurdin merged 1 commit intofeature-ldmlfrom
chore/common/7045-kmxplus-header-flag

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin commented Aug 7, 2022

Part of #7045.

Indicates that the .kmx file has additional header structure immediately following the COMP_KEYBOARD header. Used by KMXPlus file format for supporting LDML keyboards. Requires VERSION_160 or higher in keyboard file.

@keymanapp-test-bot skip

@mcdurdin mcdurdin requested a review from jahorton as a code owner August 7, 2022 12:54
@mcdurdin mcdurdin added this to the A16S8 milestone Aug 7, 2022
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Aug 7, 2022

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

Part of #7045.

Indicates that the .kmx file has additional header structure immediately
following the COMP_KEYBOARD header. Used by KMXPlus file format for
supporting LDML keyboards. Requires VERSION_160 or higher in keyboard
file.
@mcdurdin mcdurdin force-pushed the chore/common/7045-kmxplus-header-flag branch from add9780 to 1c9c652 Compare August 7, 2022 13:01
@mcdurdin mcdurdin requested review from ermshiperete, rc-swag and srl295 and removed request for jahorton August 7, 2022 13:51
KF_CAPSONONLY = $0002;
KF_CAPSALWAYSOFF = $0004;
KF_LOGICALLAYOUT = $0008;
KF_AUTOMATICVERSION = $0010;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency with C++

@srl295
Copy link
Copy Markdown
Member

srl295 commented Aug 8, 2022

LGTM

Base automatically changed from chore/common/7044-version-160 to feature-ldml August 8, 2022 16:52
@mcdurdin mcdurdin merged commit 37d44de into feature-ldml Aug 8, 2022
@mcdurdin mcdurdin deleted the chore/common/7045-kmxplus-header-flag branch August 8, 2022 16:52
@mcdurdin mcdurdin mentioned this pull request Aug 8, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants