feat(common): LDML keyboard_processor infrastructure 🙀#7048
Merged
mcdurdin merged 7 commits intofeature-ldmlfrom Aug 8, 2022
Merged
feat(common): LDML keyboard_processor infrastructure 🙀#7048mcdurdin merged 7 commits intofeature-ldmlfrom
mcdurdin merged 7 commits intofeature-ldmlfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
757fc7f to
384263d
Compare
add9780 to
1c9c652
Compare
Establishes baseline class and headers, and stub for loading LDML keyboards embedded in kmxplus files.
* Enables identification of KMXPlus files in processor factory * Adds a stub action to generate an 'a' output character * Adds a passing null_keyboard unit test for a hypothetical ldml keyboard
384263d to
6f61b1d
Compare
srl295
reviewed
Aug 8, 2022
srl295
approved these changes
Aug 8, 2022
|
|
||
| file.close(); | ||
|
|
||
| const kmx::PCOMP_KEYBOARD comp_keyboard = (kmx::PCOMP_KEYBOARD)data.data(); |
Member
Author
There was a problem hiding this comment.
😭 VC++ won't let me and I haven't yet figured out why.
Base automatically changed from
chore/common/7045-kmxplus-header-flag
to
feature-ldml
August 8, 2022 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature description: #7042.
Establishes baseline class and headers, and stub for loading LDML keyboards embedded in kmxplus files.
@keymanapp-test-bot skip