feat(web): start of the GestureRecognizer class, use of event-based paradigm 🐵#6843
Merged
jahorton merged 12 commits intofeat/web/gesture-recognizer-mainfrom Jul 14, 2022
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
1 task
4ddfbdf to
e03e5ab
Compare
1d3ff60 to
6b42436
Compare
Contributor
Author
|
Whoops! Made changes intended for the base branch on this one instead. I'm fixing that up now. |
…/web/gesture-recognizer-base
Contributor
Author
|
Okay, git was able to resolve things without much issue. Commit history will look a bit messy, but it's better than attempting a full-on rebase at this point. |
…/web/gesture-recognizer-base
Contributor
Author
|
Don't be concerned about those failed builds; I nuked them on the CI server since:
|
…/web/gesture-recognizer-base
mcdurdin
requested changes
Jul 12, 2022
Member
mcdurdin
left a comment
There was a problem hiding this comment.
Looks pretty clean overall. A few nits only.
Contributor
Author
Note to self:
Done. |
mcdurdin
approved these changes
Jul 14, 2022
Co-authored-by: Marc Durdin <marc@durdin.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than require constant reference to two separate event engines... why not provide a way for them to be integrated into a single class? Of course, for readability's sake... there's no need to actually fuse them. Also, I think it'll be quite helpful to keep mouse-handling state variables separate from touch-handling state variables... as more such variables will likely be added in the future. (Especially once we start aiming to handle multi-touch!)
Rather than have a rather messy callback-configuration setup for the classes, this also retools the input-receiving engines to use an event-based paradigm; this provides a simple event interface that code can attach a listener to for updates. It's a cleaner interface and will better fit the needs of the future
GestureSegmentercomponent of the module.@keymanapp-test-bot skip