feat(android): Add menu to specify long-press delay#12170
Merged
darcywong00 merged 8 commits intomasterfrom Aug 20, 2024
Merged
feat(android): Add menu to specify long-press delay#12170darcywong00 merged 8 commits intomasterfrom
darcywong00 merged 8 commits intomasterfrom
Conversation
User Test Results |
Test ResultsI tested this issue with the attached "Keyman 18.0.88-alpha-test-12170" build on the Android 14 physical device and Android 9(emulator) Here is my observation.
0.5s is the minimum time and 1.5s maximum time. I can alter the timing and make it available when I reopen the app. |
mcdurdin
approved these changes
Aug 19, 2024
android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/AdjustLongpressDelayActivity.java
Outdated
Show resolved
Hide resolved
…ustLongpressDelayActivity.java Co-authored-by: Marc Durdin <marc@durdin.net>
Collaborator
|
Changes in this pull request will be available for download in Keyman version 18.0.93-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the UI portion of #877.
A separate PR will integrate passing the custom long-press duration into KeymanWeb.
The slider in the menu has discrete positions from [0,7] and correspond to long-press durations 0.3s to 1.5s.
Internally, they code keeps track of the current long-press delay as milliseconds, and the default KeymanWeb duration is 500ms.
Screenshots
The menu to adjust the long-press delay is accessed in Keyman Settings
Position at default 0.5s
Position at 1.3s
User Testing
Setup - Install the PR build of Keyman for Android