Skip to content

chore(web): finalize web/ project parity with base-repo TS config settings (aside from JS version target) 🔩#11464

Merged
jahorton merged 3 commits intomasterfrom
chore/web/final-config-flag-fixes
Jun 3, 2024
Merged

chore(web): finalize web/ project parity with base-repo TS config settings (aside from JS version target) 🔩#11464
jahorton merged 3 commits intomasterfrom
chore/web/final-config-flag-fixes

Conversation

@jahorton
Copy link
Copy Markdown
Contributor

@jahorton jahorton commented May 16, 2024 •
edited
Loading

For some reason, I expected these final flags to be worse than enforcing strictFunctionTypes. Maybe it's due to some of the changes the previous setting triggered, but this part went quite swimmingly.

Fixes #11473.

User Testing

TEST_DEVELOPER_KMC: Using the test build of Keyman Developer, verify that keyboard compilation works properly.

  1. In your local copy of the keyboards repo, run ./build.sh clean.
  2. Open Keyman Developer.
  3. Open any keyboard project - say, ekwtamil99uni (at https://github.com/keymanapp/keyboards/tree/master/release/e/ekwtamil99uni).
  4. Use Keyboards > ekwtamil99uni.kmn > Build > Compile Keyboard and verify that no errors are emitted.
  5. Returning to the .kpj overview, use Packaging > ekwtamil99uni.kps > Build > Compile Package and verify that no errors are emitted.

TEST_DEVELOPER_SERVER: Using the test build of Keyman Developer, verify that the Web test-host page works properly for testing Web keyboards.

  1. Open Keyman Developer.
  2. Open any keyboard project - say, ekwtamil99uni (at https://github.com/keymanapp/keyboards/tree/master/release/e/ekwtamil99uni).
  3. Use Keyboards > ekwtamil99uni.kmn > Build > Compile Keyboard and verify that no errors are emitted.
  4. From the same screen, click "Test Keyboard on web", then "Open in browser".
  5. Verify that the keyboard can be selected and that it loads and types properly.

@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented May 16, 2024 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_DEVELOPER_KMC (PASSED): I tested this issue with the attached "Keyman 18.0.30-alpha-test-11464" build on the Windows 11 OS environment: Here is my observation. (notes)
  • ✅ TEST_DEVELOPER_SERVER (PASSED) (notes)

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S2 milestone May 16, 2024
@mcdurdin
Copy link
Copy Markdown
Member

mcdurdin commented May 17, 2024

Can you include a reference for why this is being done?

This was referenced May 23, 2024
Merged
Merged
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels May 23, 2024
@dinakaranr
Copy link
Copy Markdown

dinakaranr commented May 23, 2024

Test Results

  • TEST_DEVELOPER_KMC (PASSED): I tested this issue with the attached "Keyman 18.0.30-alpha-test-11464" build on the Windows 11 OS environment: Here is my observation.
  1. Get the latest changes in the keyboard repository and then ran ./build.sh clean on the "git bash prompt" window.
  2. Open Keyman Developer.
  3. Open the "ekwtamil99uni" keyboard project from the keyboards release folder. 
  4. Use Keyboards > ekwtamil99uni.kmn > Build > Compile the keyboard, and then verify that no errors appeared after compilation was completed.
  5. Navigate and return to the.kpj overview tab. Click on the Packaging tab.
  6. Click "ekwtamil99uni.kps".
  7. On the Build tab, click "Compile Package."
    Here, verify that no error appeared after the compilation was completed. "ekwtamil99uni.kmn built successfully." message appeared in green color. It works well. Thanks.
  • TEST_DEVELOPER_SERVER (PASSED):
  1. Open Keyman Developer.
  2. Open the "ekwtamil99uni" keyboard project from the keyboards release folder. 
  3. Use Keyboards > ekwtamil99uni.kmn > Build > Compile the keyboard, and then verify that no errors appeared after compilation was completed.
  4. On the "Android and iOS Targets" pane: click the "Test package on Web" button. Here, a QR quote appeared. The web address appeared in the server list box.
  5. Select the "http://localhost:8008" address and then click the "Open in browser" button.
  6. A browser window appeared with the web keyboard. Here, the keyboard is loaded on the browser.
  7. Select "ekwtamil99uni" from the "keyboard" list box.
  8. Click some keys on Web-OSK. Here, Tamil keys appeared in the "character-grid" window. It works well. Thanks.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label May 23, 2024
@mcdurdin mcdurdin modified the milestones: A18S2, A18S3 May 24, 2024
@jahorton jahorton marked this pull request as draft May 28, 2024 02:39
@jahorton jahorton force-pushed the chore/web/strict-func-types branch from af8cb63 to a94c511 Compare May 29, 2024 03:46
@jahorton jahorton force-pushed the chore/web/final-config-flag-fixes branch from 62fa316 to 70c7268 Compare May 29, 2024 03:59
@jahorton jahorton marked this pull request as ready for review May 29, 2024 04:05
@jahorton jahorton changed the title chore(web): finalizes web/ project parity with base-repo TS config settings (aside from JS version target) chore(web): finalizes web/ project parity with base-repo TS config settings (aside from JS version target) 🔩 May 29, 2024
@jahorton
chore(web): fix web package.json's typescript entry
40733e4 
It should've been fixed previously, but maybe I messed things up with this while rebasing?
@jahorton jahorton mentioned this pull request May 31, 2024
Merged
@jahorton jahorton changed the title chore(web): finalizes web/ project parity with base-repo TS config settings (aside from JS version target) 🔩 chore(web): finalize web/ project parity with base-repo TS config settings (aside from JS version target) 🔩 Jun 3, 2024
Base automatically changed from chore/web/strict-func-types to master June 3, 2024 08:16
@jahorton jahorton merged commit c3277c5 into master Jun 3, 2024
@jahorton jahorton deleted the chore/web/final-config-flag-fixes branch June 3, 2024 08:16
@keyman-server
Copy link
Copy Markdown
Collaborator

keyman-server commented Jun 3, 2024

Changes in this pull request will be available for download in Keyman version 18.0.47-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ermshiperete ermshiperete ermshiperete approved these changes

@mcdurdin mcdurdin mcdurdin approved these changes

Assignees

No one assigned

Labels

chore common/web/ common/ has-user-test web/

Projects

None yet

Milestone

A18S3

Development

Successfully merging this pull request may close these issues.

chore(web): enforce stricter TS settings for Keyman Engine for Web

5 participants

@jahorton @mcdurdin @dinakaranr @keyman-server @ermshiperete