feat(core): ldml reorder marker processing 🙀 #10539
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
bf69802 to
7cb4697
Compare
- reorders don't interact with markers, but must transit them - add updated tests - simplify reorder_group::apply(): the 'common prefix' discussion was out-of-date as std::mismatch is handled by the ldml_processor and the core context. - add_back_markers() promoted to SPI so it can be called from reordering. Fixes: #10516
- update per code review - move quickcheck of map into add_back_markers() For: #10516
9d2731c to
2c92cfe
Compare
- fix quickcheck of add_back_markers() For: #10516
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.258-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was out-of-date as std::mismatch is handled by the ldml_processor
and the core context.
Fixes: #10516
@keymanapp-test-bot skip