fix(developer): tidy up LDML keyboard project template 🌱#10474
Merged
mcdurdin merged 1 commit intoepic/core/9999-normalizationfrom Jan 26, 2024
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
srl295
approved these changes
Jan 23, 2024
Member
srl295
left a comment
There was a problem hiding this comment.
LGTM. Is there a reason the template isn't sourced from an actual xml file? might be easier to maintain.
Member
Author
Laziness. Means adding an extra file to the install template and path maintenance etc. Agree though, it would be better long-term. Also noting that the template generation as written in Delphi in this code is deprecated before it even lands because we will replace it with keyman/developer/src/kmc/src/kmc.ts Line 56 in ff87042 |
Base automatically changed from
fix/developer/10469-use-keyboard3-tag
to
epic/core/9999-normalization
January 26, 2024 04:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10470.
@keymanapp-test-bot skip