Skip to content

refactor(developer): update app context as well as cached context for keyboard debuggers 🌱#10462

Merged
mcdurdin merged 3 commits intoepic/core/9999-normalizationfrom
refactor/developer/10214-debugger-app-context
Jan 25, 2024
Merged

refactor(developer): update app context as well as cached context for keyboard debuggers 🌱#10462
mcdurdin merged 3 commits intoepic/core/9999-normalizationfrom
refactor/developer/10214-debugger-app-context

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin commented Jan 22, 2024

Fixes #10214.

User Testing

  • TEST_DEBUGGER: Open a .kmn keyboard project and verify that keyboard debugger continues to function correctly through a series of tests.

@mcdurdin mcdurdin requested a review from darcywong00 as a code owner January 22, 2024 01:43
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Jan 22, 2024
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Jan 22, 2024 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_DEBUGGER (PASSED): Retested with the updated PR build (Keyman Developer 17.0.248-alpha-test-10462) in Windows 10 OS and here is my observation: 1. Got a warning message after pressing the F5 key from the keyboard. 2. So, I closed the project. Removed .json files from C:\Users\Admin\AppData\Roaming\Keyman\Keyman Developer. 3. Opened another project (eg., malar_malayalam). Clicked the uprgrade project button from the project window. 4. Pressing F5 key after opening the project. 5. Verified that it is working fine after using the project in the Debugger window. Seems to be working fine. (notes)

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S31 milestone Jan 22, 2024
@mcdurdin mcdurdin linked an issue Jan 22, 2024 that may be closed by this pull request
refactor(developer): debugger: manage app_context as well as cached_context 🌱 #10214
Closed
@bharanidharanj
Copy link
Copy Markdown

bharanidharanj commented Jan 22, 2024

Test Results

  • TEST_DEBUGGER (FAILED): Tested with the attached PR build (Keyman Developer 17.0.247-alpha-test-10462) on Windows 10 OS and here is my observation: 1. Created a new Keyman Keyboard (.kmn) project. 2. Compiled it. 3. Opened the debugger by pressing F5 key. 3. Pressing 'a' key from the keyboard leads to an error message. Seems to be an issue.

..Fatal error

..Error message in Node window

@keymanapp-test-bot keymanapp-test-bot bot changed the title refactor(developer): update app context as well as cached context for keyboard debuggers refactor(developer): update app context as well as cached context for keyboard debuggers 🌱 Jan 22, 2024
srl295
srl295 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like good refactoring

@mcdurdin
Copy link
Copy Markdown
Member Author

mcdurdin commented Jan 24, 2024

Hi @bharanidharanj, can you retest this one, once the build finishes, as I have made some updates. I am not sure that it is going to address the problem but would like to retest before I dig deeper if possible, thanks!

@keymanapp-test-bot retest

@keymanapp-test-bot keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Jan 24, 2024
Base automatically changed from fix/developer/10456-ldml-keyboard-editor-font to epic/core/9999-normalization January 25, 2024 08:30
@bharanidharanj
Copy link
Copy Markdown

bharanidharanj commented Jan 25, 2024

Test Results

  • TEST_DEBUGGER (PASSED): Retested with the updated PR build (Keyman Developer 17.0.248-alpha-test-10462) in Windows 10 OS and here is my observation: 1. Got a warning message after pressing the F5 key from the keyboard. 2. So, I closed the project. Removed .json files from C:\Users\Admin\AppData\Roaming\Keyman\Keyman Developer. 3. Opened another project (eg., malar_malayalam). Clicked the uprgrade project button from the project window. 4. Pressing F5 key after opening the project. 5. Verified that it is working fine after using the project in the Debugger window. Seems to be working fine.

..warning message

..working fine in the debugger window

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 25, 2024
@mcdurdin mcdurdin merged commit 6212b47 into epic/core/9999-normalization Jan 25, 2024
@mcdurdin mcdurdin deleted the refactor/developer/10214-debugger-app-context branch January 25, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295 srl295 srl295 approved these changes

@darcywong00 darcywong00 Awaiting requested review from darcywong00

Assignees

No one assigned

Labels

developer/ide/ developer/ has-user-test refactor

Projects

None yet

Milestone

A17S31

Development

Successfully merging this pull request may close these issues.

refactor(developer): debugger: manage app_context as well as cached_context 🌱

3 participants

@mcdurdin @bharanidharanj @srl295