Skip to content

fix(web): heterogenous longpress roaming 🐵#10172

Merged
jahorton merged 2 commits intofeature-gesturesfrom
fix/web/roaming-longpresses
Dec 8, 2023
Merged

fix(web): heterogenous longpress roaming 🐵#10172
jahorton merged 2 commits intofeature-gesturesfrom
fix/web/roaming-longpresses

Conversation

@jahorton
Copy link
Copy Markdown
Contributor

@jahorton jahorton commented Dec 7, 2023

Fixes #10170.
Fixes #10171.

Longpress validation now occurs when the longpress would trigger, rather than on the initial key-down. If the timer elapses on a key that doesn't support longpresses and roaming mode is disabled, the gesture-engine will enter a state that restores longpress processing when the base key changes - including a restart of the longpress timer.

User Testing

TEST_ROAM_FROM_SUBKEYLESS: Using the "Predictive Text: Robust Testing" KeymanWeb test page...

  1. Select the "SIL EuroLatin" keyboard (under English).

  2. Swap to the numeric layer.

  3. Press and hold the & key for at least a second.

  4. Move your finger over the % key and hold.

  5. Verify that after a moment, a subkey menu appears with these options: ‰, ‱

    In case of bad GitHub rendering:
    image

TEST_ROAM_TO_SUBKEYLESS: Using the "Predictive Text: Robust Testing" KeymanWeb test page...

  1. Select the "SIL EuroLatin" keyboard (under English).
  2. Swap to the numeric layer.
  3. Press and hold the % key, then quickly move to the & key for at least a second.
  4. Return your finger to the % key and hold.
  5. Verify that after a moment, a subkey menu appears with these options: ‰, ‱

TEST_BIG_ROAM: Using the "Predictive Text: Robust Testing" KeymanWeb test page...

  1. Select the "SIL EuroLatin" keyboard (under English).
  2. Swap to the numeric layer.
  3. Press and hold the 1 key, then quickly move to the $ key for at least a second.
  4. Move your finger toward the right across the entire second row of keys, landing on the / key.
  5. Verify that after a moment, a subkey menu appears for the / key with this option: \

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Dec 7, 2023
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Dec 7, 2023 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_ROAM_FROM_SUBKEYLESS (PASSED): Tested using the "Predictive Text:Robus Testing" KeymanWeb test page on Android Mobile (ver 13) and here is my observation: 1. Opened the mentioned web test page on the Chrome browser. 2. Selected the "EuroLatin(SIL)" keyboard under English. 3. Swapped to the numeric layer. Press and hold the & key then moved the finger over the % key and hold. Verified that after a moment, a subkey menu appear with the following options: ‰, ‱
  • ✅ TEST_ROAM_TO_SUBKEYLESS (PASSED): 1. Selected the "EuroLatin(SIL)" keyboard under English. 2. Swapped to the numeric layer. 3. Press and hold the % key, then quickly moved to & key. Return my finger to the % key and hold it. 4. Verified that after a moment, a subkey menu appears with these options: ‰, ‱
  • ✅ TEST_BIG_ROAM (PASSED): 1. Selected the "EuroLatin(SIL)" keyboard under English. 2. Swapped to the numeric layer.3. Press and hold the 1 key, then quickly moved to the $ key. 4. Moved my finger towards right across the entire second row of keys, landing on the / key. 5. Verified that after moment, a subkey menu appears for the / key with this option: \

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(web): heterogenous longpress roaming fix(web): heterogenous longpress roaming 🐵 Dec 7, 2023
@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S27 milestone Dec 7, 2023
@bharanidharanj
Copy link
Copy Markdown

bharanidharanj commented Dec 7, 2023

Test Results

  • TEST_ROAM_FROM_SUBKEYLESS (PASSED): Tested using the "Predictive Text:Robus Testing" KeymanWeb test page on Android Mobile (ver 13) and here is my observation: 1. Opened the mentioned web test page on the Chrome browser. 2. Selected the "EuroLatin(SIL)" keyboard under English. 3. Swapped to the numeric layer. Press and hold the & key then moved the finger over the % key and hold. Verified that after a moment, a subkey menu appear with the following options: ‰, ‱

  • TEST_ROAM_TO_SUBKEYLESS (PASSED): 1. Selected the "EuroLatin(SIL)" keyboard under English. 2. Swapped to the numeric layer. 3. Press and hold the % key, then quickly moved to & key. Return my finger to the % key and hold it. 4. Verified that after a moment, a subkey menu appears with these options: ‰, ‱

  • TEST_BIG_ROAM (PASSED): 1. Selected the "EuroLatin(SIL)" keyboard under English. 2. Swapped to the numeric layer.3. Press and hold the 1 key, then quickly moved to the $ key. 4. Moved my finger towards right across the entire second row of keys, landing on the / key. 5. Verified that after moment, a subkey menu appears for the / key with this option: \

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Dec 7, 2023
mcdurdin
mcdurdin approved these changes Dec 8, 2023
View reviewed changes
@jahorton @mcdurdin
chore(web): Apply suggestions from code review
a4373f1 
Co-authored-by: Marc Durdin <marc@durdin.net>
This was linked to issues Dec 8, 2023
bug(web): roaming touches starting on non-longpress keys will never trigger longpresses 🐵 #10170
Closed
bug(web): roaming from longpressable key to nonlongpressable and attempting longpress on it throws an error 🐵 #10171
Closed
@mcdurdin mcdurdin modified the milestones: A17S27, A17S28 Dec 8, 2023
@jahorton jahorton merged commit 876fe0b into feature-gestures Dec 8, 2023
@jahorton jahorton deleted the fix/web/roaming-longpresses branch December 8, 2023 08:36
@jahorton jahorton mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ermshiperete ermshiperete ermshiperete approved these changes

@mcdurdin mcdurdin mcdurdin approved these changes

Assignees

No one assigned

Labels

common/web/ common/ epic-gestures fix has-user-test web/

Projects

None yet

Milestone

A17S28

4 participants

@jahorton @bharanidharanj @ermshiperete @mcdurdin