Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
This was referenced Dec 6, 2023
darcywong00
reviewed
Dec 7, 2023
| } | ||
|
|
||
| // Give a hint if the project is v1.0 | ||
| if(this.project.options.version != '2.0') { |
Contributor
There was a problem hiding this comment.
Wouldn't a version comparison (< 2.0) future-proof this check?
Member
Author
There was a problem hiding this comment.
Perhaps, but we'll need to revisit all this anyway if we want to upgrade project file versions again, and we may want to do something different for that case.
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.228-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10147.
@keymanapp-test-bot skip