Skip to content

fix(common): kpj loader needs to handle empty Files element 🦕#10157

Merged
mcdurdin merged 2 commits intomasterfrom
fix/common/10143-kpj-handle-empty-files-element
Dec 11, 2023
Merged

fix(common): kpj loader needs to handle empty Files element 🦕#10157
mcdurdin merged 2 commits intomasterfrom
fix/common/10143-kpj-handle-empty-files-element

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin commented Dec 6, 2023

Fixes #10143.

@markcsinclair you may want to review this one 😁

@keymanapp-test-bot skip

@mcdurdin mcdurdin requested a review from jahorton as a code owner December 6, 2023 05:37
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin changed the title fix(common): kpj loader needs to handle empty Files element fix(common): kpj loader needs to handle empty Files element 🦕 Dec 6, 2023
@mcdurdin mcdurdin modified the milestones: A17S27, A17S28 Dec 8, 2023
@mcdurdin mcdurdin merged commit 03625c6 into master Dec 11, 2023
@mcdurdin mcdurdin deleted the fix/common/10143-kpj-handle-empty-files-element branch December 11, 2023 14:12
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.228-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(common): kmc cannot load a v1.0 project which has no files

3 participants