Add support for downloading favicons after saving a credential#1472
Merged
varjolintu merged 2 commits intodevelopfrom Dec 11, 2021
Merged
Add support for downloading favicons after saving a credential#1472varjolintu merged 2 commits intodevelopfrom
varjolintu merged 2 commits intodevelopfrom
Conversation
droidmonkey
approved these changes
Dec 10, 2021
| credentialSorting: SORT_BY_GROUP_AND_TITLE, | ||
| defaultGroup: '', | ||
| defaultGroupAlwaysAsk: false, | ||
| downloadFaviconAfterSave: false, |
Member
There was a problem hiding this comment.
I didn't realize this was disabled by default and thought the code was broken. Perhaps we should enable this by default instead?
Member
Author
There was a problem hiding this comment.
On the other hand I would assume users don't want to make any network connections from KeePassXC by default.
|
I am using the current Browser Plugin, but can not find the option to enable it. |
Member
Author
|
@ChrTall You'll need to use KeePassXC 2.7.0 snapshot until the stable version is released. 2.6.6 doesn't have support for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new command parameter for supportin favicon download after a credential has been saved.
An implementation is needed to the KeePassXC side. Let's keep this WIP until then.
Related KeePassXC PR: keepassxreboot/keepassxc#7179
Fixes #86.