Skip to content

Download favicon in the background after credential add#7179

Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom
varjolintu:feature/download_favicon_after_credential_add
Dec 12, 2021
Merged

Download favicon in the background after credential add#7179
droidmonkey merged 1 commit intokeepassxreboot:developfrom
varjolintu:feature/download_favicon_after_credential_add

Conversation

@varjolintu
Copy link
Copy Markdown
Member

Downloads a favicon in the background if set by keepassxreboot/keepassxc-browser#1472.
The feature is only available via the browser extension.

Testing strategy

Manually.

Type of change

  • ✅ New feature (change that adds functionality)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 26, 2021

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 64.25%. Comparing base (d16fc2d) to head (da9eaad).
Report is 547 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/IconDownloaderDialog.cpp 0.00% 15 Missing ⚠️
src/gui/DatabaseWidget.cpp 0.00% 8 Missing ⚠️
src/browser/BrowserAction.cpp 0.00% 3 Missing ⚠️
src/browser/BrowserService.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7179      +/-   ##
===========================================
- Coverage    64.26%   64.25%   -0.01%     
===========================================
  Files          336      336              
  Lines        42344    42369      +25     
===========================================
+ Hits         27212    27223      +11     
- Misses       15132    15146      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@varjolintu varjolintu force-pushed the feature/download_favicon_after_credential_add branch from 9c69a9a to 4de6601 Compare November 26, 2021 18:43
@droidmonkey droidmonkey force-pushed the feature/download_favicon_after_credential_add branch from 4de6601 to da9eaad Compare December 11, 2021 03:12
@droidmonkey droidmonkey merged commit 12d16f6 into keepassxreboot:develop Dec 12, 2021
@varjolintu varjolintu deleted the feature/download_favicon_after_credential_add branch December 12, 2021 13:23
@phoerious phoerious added pr: new feature Pull request adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: Browser pr: new feature Pull request adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants