Use Icons for password strength#9844
Merged
droidmonkey merged 6 commits intokeepassxreboot:developfrom Aug 12, 2024
Merged
Conversation
Member
|
Oh I love the one with the exclamation point. I'd make it a little bigger/bolder, but that is great! |
Contributor
Author
|
Sadly i am not good at editing svg's. |
Member
|
I can handle that part |
Member
|
You didn't commit the new icon SVG's |
Contributor
Author
|
@droidmonkey Oops, sorry. I fixed that. |
dmaslenko
reviewed
Dec 30, 2023
Contributor
Author
|
@droidmonkey Should be good to go now! |
Member
|
Oh great, will queue this back up |
3065294 to
bf9c538
Compare
23cfb8f to
932574a
Compare
Member
|
Improved the exclamation point icon a bit, ready to go:
|
droidmonkey
approved these changes
Aug 12, 2024
droidmonkey
added a commit
that referenced
this pull request
Aug 14, 2024
--------- Co-authored-by: Jonathan White <support@dmapps.us>
droidmonkey
added a commit
that referenced
this pull request
Aug 14, 2024
--------- Co-authored-by: Jonathan White <support@dmapps.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the discussion here: #6798 (comment)
I replaced the color indicator by a colored lock icon.
Screenshots
Alternative:
Report:
Testing strategy
Manually. Its only a visual style and heavily reuses existing code.
Type of change