fix CreateFileMappingA Parameter#8619
Merged
droidmonkey merged 3 commits intokeepassxreboot:developfrom Oct 28, 2022
Merged
Conversation
The last argument of CreateFileMappingA is of type string.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8619 +/- ##
===========================================
+ Coverage 64.26% 64.28% +0.02%
===========================================
Files 341 341
Lines 44334 44334
===========================================
+ Hits 28488 28496 +8
+ Misses 15846 15838 -8 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Member
|
Interesting this has been in code for long time and it still worked. Good catch though! |
droidmonkey
approved these changes
Oct 28, 2022
pull bot
pushed a commit
to Tiamat-Tech/keepassxc
that referenced
this pull request
Oct 28, 2022
The last argument of CreateFileMappingA is of type string.
droidmonkey
pushed a commit
that referenced
this pull request
Oct 29, 2022
The last argument of CreateFileMappingA is of type string.
Merged
droidmonkey
pushed a commit
that referenced
this pull request
Oct 29, 2022
The last argument of CreateFileMappingA is of type string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last argument of CreateFileMappingA is of type string.
There was a difference in the original implementation of putty(pageant)'s pageant protocol.
In putty(pageant), the thread ID given to the CreateFileMapping mapName is the string '%08x', but in keepassxc, it was a binary number as the thread ID.
According to the CreateFileMapping documentation, the last argument must be of type string.
Changed the thread ID to be assigned to the map name in CreateFileMapping to be an 8-digit hexadecimal number, the same as putty.
Testing strategy
I built on Windows 10 and verified that adding/deleting keys in pageant works correctly.
Type of change