Fix Best-Matching ..again#5316
Merged
droidmonkey merged 2 commits intokeepassxreboot:release/2.6.2from Sep 13, 2020
Merged
Conversation
41fd664 to
f2156da
Compare
Member
|
The whole logic tree needs a refactor. I suspect we are also not handling multiple urls correctly. |
Member
Author
|
@droidmonkey That needs to be checked too. |
MaxXor
approved these changes
Aug 22, 2020
Member
Author
|
Tested the Additional URL's behavior with the following scenario:
EDIT: And of course, I'm making a test case. EDIT 2: Made a change inside |
Member
|
Is this ready for review? |
Member
Author
|
@droidmonkey Yes. |
droidmonkey
pushed a commit
to varjolintu/keepassxc
that referenced
this pull request
Aug 31, 2020
* Fixes keepassxreboot#5316 * Added some more tests
b942172 to
22e59f3
Compare
droidmonkey
requested changes
Aug 31, 2020
* Handle Additional URLs when doing priority sorting * Clean up function calls * Fixes keepassxreboot#5299
3a38703 to
421f499
Compare
421f499 to
577bbce
Compare
droidmonkey
approved these changes
Sep 12, 2020
Member
droidmonkey
left a comment
There was a problem hiding this comment.
Fixed remaining issues with Qt < 5.11
phoerious
added a commit
that referenced
this pull request
Oct 21, 2020
Added - Add option to keep window always on top to view menu [#5542] - Move show/hide usernames and passwords to view menu [#5542] - Add command line options and environment variables for changing the config locations [#5452] - Include TOTP settings in CSV import/export and add support for ISO datetimes [#5346] Changed - Mask sensitive information in command execution confirmation prompt [#5542] - SSH Agent: Avoid shortcut conflict on macOS by changing "Add key" to Ctrl+H on all platforms [#5484] Fixed - Prevent data loss with drag and drop between databases [#5536] - Fix crash when toggling Capslock rapidly [#5545] - Don't mark URL references as invalid URL [#5380] - Reset entry preview after search [#5483] - Set Qt::Dialog flag on database open dialog [#5356] - Fix sorting of database report columns [#5426] - Fix IfDevice matching logic [#5344] - Fix layout issues and a stray scrollbar appearing on top of the entry edit screen [#5424] - Fix tabbing into the notes field [#5424] - Fix password generator ignoring settings on load [#5340] - Restore natural entry sort order on application load [#5438] - Fix paperclip and TOTP columns not saving state [#5327] - Enforce fixed password font in entry preview [#5454] - Add scrollbar when new database wizard exceeds screen size [#5560] - Do not mark database as modified when viewing Auto-Type associations [#5542] - CLI: Fix two heap-use-after-free crashes [#5368,#5470] - Browser: Fix key exchange not working with multiple simultaneous users on Windows [#5485] - Browser: Fix entry retrieval when "only best matching" is enabled [#5316] - Browser: Ignore recycle bin on KeePassHTTP migration [#5481] - KeeShare: Fix import crash [#5542] - macOS: Fix toolbar theming and breadcrumb display issues [#5482] - macOS: Fix file dialog randomly closing [#5479] - macOS: Fix being unable to select OPVault files for import [#5341]
This was referenced Dec 2, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was still broken. And actually the change for passing a full URL from the extension fixed the issue without any extra handling in the BrowserService.cpp.
Fixes #5299.
Testing strategy
Added some more tests, and tested it also manually. Double verification will be needed. This should be the final fix for this. Really.
Type of change