Skip to content

Allow manual editing of browser extension connection keys & add option for custom extension ID#4591

Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom
varjolintu:feature/edit_browser_keys
May 15, 2020
Merged

Allow manual editing of browser extension connection keys & add option for custom extension ID#4591
droidmonkey merged 1 commit intokeepassxreboot:developfrom
varjolintu:feature/edit_browser_keys

Conversation

@varjolintu
Copy link
Copy Markdown
Member

@varjolintu varjolintu commented Apr 12, 2020

Type of change

  • ✅ New feature (non-breaking change which adds functionality)

Description and Context

Allows editing the browser extension connection keys. Both key and identifier value can be changed. Editing "Created" timestamp is not allowed.

Editing works using double click on the mouse. A keyboard shortcut could be also added if needed.

Also adds an option to use a custom extension ID with debug builds.

Fixes #3819.

Screenshots

Screen Shot 2020-04-13 at 11 16 19

Testing strategy

Manually.

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@droidmonkey
Copy link
Copy Markdown
Member

Along with this, in debug builds only, can we have the ability to add a custom extension ID that will be output in the native messaging json file?

@varjolintu
Copy link
Copy Markdown
Member Author

@droidmonkey That would be a really nice addition. I'm already tired of editing the JSON files when debugging.

@varjolintu
Copy link
Copy Markdown
Member Author

@droidmonkey The feature has been added to the PR.

@varjolintu varjolintu changed the title Allow manual editing of browser extension connection keys Allow manual editing of browser extension connection keys & add option for custom extension ID Apr 13, 2020
@varjolintu varjolintu force-pushed the feature/edit_browser_keys branch from 61791af to 1122c70 Compare April 17, 2020 04:13
@droidmonkey droidmonkey force-pushed the feature/edit_browser_keys branch from 1122c70 to ae7b789 Compare May 14, 2020 20:32
@droidmonkey droidmonkey force-pushed the feature/edit_browser_keys branch from ae7b789 to 159170c Compare May 14, 2020 21:32
@droidmonkey droidmonkey merged commit 287e822 into keepassxreboot:develop May 15, 2020
@varjolintu varjolintu deleted the feature/edit_browser_keys branch May 15, 2020 03:39
droidmonkey added a commit that referenced this pull request Jul 7, 2020
Added

- Custom Light and Dark themes [#4110, #4769, #4791, #4796, #4892, #4915]
- Compact mode to use classic Group and Entry line height [#4910]
- View menu to quickly switch themes, compact mode, and toggle UI elements [#4910]
- Search for groups and scope search to matched groups [#4705]
- Save Database Backup feature [#4550]
- Sort entries by "natural order" and move lines up/down [#4357]
- Option to launch KeePassXC on system startup/login [#4675]
- Caps Lock warning on password input fields [#3646]
- Add "Size" column to entry view [#4588]
- Browser-like tab experience using Ctrl+[Num] (Alt+[Num] on Linux) [#4063, #4305]
- Password Generator: Define additional characters to choose from [#3876]
- Reports: Database password health check (offline) [#3993]
- Reports: HIBP online service to check for breached passwords [#4438]
- Auto-Type: DateTime placeholders [#4409]
- Browser: Show group name in results sent to browser extension [#4111]
- Browser: Ability to define a custom browser location (macOS and Linux only) [#4148]
- Browser: Ability to change root group UUID and inline edit connection ID [#4315, #4591]
- CLI: `db-info` command [#4231]
- CLI: Use wl-clipboard if xclip is not available (Linux) [#4323]
- CLI: Incorporate xclip into snap builds [#4697]
- SSH Agent: Key file path env substitution, SSH_AUTH_SOCK override, and connection test [#3769, #3801, #4545]
- SSH Agent: Context menu actions to add/remove keys [#4290]

Changed

- Complete replacement of default database icons [#4699]
- Complete replacement of application icons [#4066, #4161, #4203, #4411]
- Complete rewrite of documentation and manpages using Asciidoctor [#4937]
- Complete refactor of config files; separate between local and roaming [#4665]
- Complete refactor of browser integration and proxy code [#4680]
- Complete refactor of hardware key integration (YubiKey and OnlyKey) [#4584, #4843]
- Significantly improve performance when saving and opening databases [#4309, #4833]
- Remove read-only detection for database files [#4508]
- Overhaul of password fields and password generator [#4367]
- Replace instances of "Master Key" with "Database Credentials" [#4929]
- Change settings checkboxes to positive phrasing for consistency [#4715]
- Improve UX of using entry actions (focus fix) [#3893]
- Set expiration time to Now when enabling entry expiration [#4406]
- Always show "New Entry" in context menu [#4617]
- Issue warning before adding large attachments [#4651]
- Improve importing OPVault [#4630]
- Improve AutoOpen capability [#3901, #4752]
- Check for updates every 7 days even while still running [#4752]
- Improve Windows installer UI/UX [#4675]
- Improve config file handling of portable distribution [#4131, #4752]
- macOS: Hide dock icon when application is hidden to tray [#4782]
- Browser: Use unlock dialog to improve UX of opening a locked database [#3698]
- Browser: Improve database and entry settings experience [#4392, #4591]
- Browser: Improve confirm access dialog [#2143, #4660]
- KeeShare: Improve monitoring file changes of shares [#4720]
- CLI: Rename `create` command to `db-create` [#4231]
- CLI: Cleanup `db-create` options (`--set-key-file` and `--set-password`) [#4313]
- CLI: Use stderr for help text and password prompts [#4086, #4623]
- FdoSecrets: Display existing secret service process [#4128]

Fixed

- Fix changing focus around the main window using tab key [#4641]
- Fix search field clearing while still using the application [#4368]
- Improve search help widget displaying on macOS and Linux [#4236]
- Return keyboard focus after editing an entry [#4287]
- Reset database path after failed "Save As" [#4526]
- Use SHA256 Digest for Windows code signing [#4129]
- Improve handling of ccache when building [#4104, #4335]
- macOS: Properly re-hide application window after browser integration and Auto-Type usage [#4909]
- Auto-Type: Fix crash when performing on new entry [#4132]
- Browser: Send legacy HTTP settings to recycle bin [#4589]
- Browser: Fix merging browser keys [#4685]
- CLI: Fix encoding when exporting database [#3921]
- SSH Agent: Improve reliability and underlying code [#3833, #4256, #4549, #4595]
- FdoSecrets: Fix crash when editing settings before service is enabled [#4332]
@phoerious phoerious added pr: new feature Pull request adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: Browser pr: new feature Pull request adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow manual entry/editing of KeePassXC-Browser keys

3 participants