Last round of fixes for 2.5.2#4075
Merged
droidmonkey merged 7 commits intorelease/2.5.2from Jan 3, 2020
Merged
Conversation
* Remove deprecation warnings when not doing a DEV_BUILD. Qt 5.14 introduced several deprecation flags on basic function calls in QList and QSet that would require several #pragma ignores. Assuming this was in preparation to Qt 6.0. * Remove unnecessary assert in PasswordEditWidget that was hit in macOS debug builds.
* Explicitly resize the window to improve testing on High DPI displays * Add additional bootstrap calls to mimic the actual application
phoerious
approved these changes
Jan 3, 2020
droidmonkey
added a commit
that referenced
this pull request
Jan 4, 2020
Added - Browser: Show UI warning when entering invalid URLs [#3912] - Browser: Option to use an entry only for HTTP auth [#3927] Changed - Disable the user interface when merging or saving the database [#3991] - Ability to hide protected attribute after reveal [#3877] - Remove mention of "snaps" in Windows and macOS [#3879] - CLI: Merge parameter for source database key file (--key-file-from) [#3961] - Improve GUI tests reliability on Hi-DPI displays [#4075] - Disable deprecation warnings to allow building with Qt 5.14+ [#4075] - OPVault: Use 'otp' attribute for TOTP field imports [#4075] Fixed - Fix crashes when saving a database to cloud storage [#3991] - Fix crash when pressing enter twice while opening database [#3885] - Fix handling of HTML when displayed in the entry preview panel [#3910] - Fix start minimized to tray on Linux [#3899] - Fix Auto Open with key file only databases [#4075] - Fix escape key closing the standalone password generator [#3892] - macOS: Fix monospace font usage in password field and notes [#4075] - macOS: Fix building on macOS 10.9 to 10.11 [#3946] - Fix TOTP setup dialog not closing on database lock [#4075] - Browser: Fix condition where additional URLs are ignored [#4033] - Browser: Fix subdomain matching to return only relevant site entries [#3854] - Secret Service: Fix multiple crashes and incompatibilities [#3871, #4009, #4074] - Secret Service: Fix searching of entries [#4008, #4036] - Secret Service: Fix behavior when exposed group is recycled [#3914] - CLI: Release the database instance before exiting interactive mode [#3889] - Fix (most) memory leaks in tests [#3922]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description and Context
Last bit of 2.5.2 bug fixes:
Fix compiler issues with Qt 5.14
Choose a better monospace font on macOS (Fixes macOS Sierra: Password text box font size, at "View/Edit entry" window, is too small #1917)
Hide snap browser warning label on non-Linux OS (Fixes macOS and Windows shouldn't talk about snaps #3707)
Fix AutoOpen with key file only databases (Fixes AutoOpen only works if password is not empty #3931)
Use new TOTP structure when importing 1Password Vault (Fixes OPVault importer uses legacy attribute for TOTP secrets #3999)
Fix TOTP Dialog not closing on lock
Improve GUI test reliability
Testing strategy
Ran all tests locally and on macOS
Checklist:
-DWITH_ASAN=ON. [REQUIRED]