Fix build on NetBSD.#1557
Merged
phoerious merged 2 commits intokeepassxreboot:developfrom Feb 28, 2018
Merged
Conversation
Contributor
|
Apparently I missed in #283 Adding the need-work tag since I think it's better to perform a UNIX check, Target release 2.3.1 The check should be |
Contributor
Author
|
Thanks for looking at this so quickly. I've added a second patch per your request (tested, works for me). |
TheZ3ro
approved these changes
Feb 28, 2018
Contributor
TheZ3ro
left a comment
There was a problem hiding this comment.
Thanks, looks fine for me
phoerious
approved these changes
Feb 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch I see:
You should consider making this a UNIX check instead, but the patch fixes the immediate problem on NetBSD.