Passkeys: Add publicKey to register response#12757
Merged
phoerious merged 4 commits intokeepassxreboot:developfrom Jan 17, 2026
Merged
Passkeys: Add publicKey to register response#12757phoerious merged 4 commits intokeepassxreboot:developfrom
phoerious merged 4 commits intokeepassxreboot:developfrom
Conversation
This was referenced Nov 29, 2025
017fc17 to
fee044d
Compare
Member
Author
|
Need to add some exceptions for Botan 2. |
Member
|
Can we add a test for this response? |
Member
Author
I'll try. We use predefined values for the keys so it should be possible. EDIT: We are not actually creating any keys in the tests so.. I'll try to modify the tests so we can create actual keys with const predefined data. |
06ecbea to
d0735de
Compare
Member
Author
|
Modified the And of course the private key data changes affected to some other tests too. |
droidmonkey
approved these changes
Nov 29, 2025
phoerious
pushed a commit
that referenced
this pull request
Jan 17, 2026
phoerious
pushed a commit
that referenced
this pull request
Mar 8, 2026
phoerious
pushed a commit
that referenced
this pull request
Mar 8, 2026
phoerious
pushed a commit
that referenced
this pull request
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a DER SubjectPublicKeyInfo to the passkey registration response. We are currently not writing this, even if It is part of the specification https://w3c.github.io/webauthn/#sctn-public-key-easy:
Fixes a passkey creation on Logitech site https://id.logi.com.
Testing strategy
Manually with: keepassxreboot/keepassxc-browser#2782
Tested https://webauthn.io with all three different algorithms to verify the response has the new
publicKeyin base64 format in the browser logs.Type of change