Skip to content

Revert Auto-Type change that caused race condition#12738

Merged
phoerious merged 1 commit intodevelopfrom
fix/autotype-delay
Mar 8, 2026
Merged

Revert Auto-Type change that caused race condition#12738
phoerious merged 1 commit intodevelopfrom
fix/autotype-delay

Conversation

@droidmonkey
Copy link
Copy Markdown
Member

@droidmonkey droidmonkey commented Nov 25, 2025

Testing strategy

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

@droidmonkey droidmonkey added this to the v2.7.12 milestone Nov 25, 2025
Copilot AI reviewed Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a race condition in the Auto-Type functionality by reverting a previous change and restructuring how the initial start delay is handled. The key insight is that the initial delay must be executed synchronously before grabbing the active window reference, rather than being queued as an action in the actions list.

Key Changes:

  • Moved initial Auto-Type delay execution from the action queue to direct execution before window capture
  • Introduced file-scoped constants s_minWaitDelay (100ms) and s_maxWaitDelay (10s) for consistent delay validation
  • Updated all delay validation logic to use the new constants instead of local variables

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.42%. Comparing base (967dc59) to head (f48fd6b).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #12738   +/-   ##
========================================
  Coverage    64.42%   64.42%           
========================================
  Files          378      378           
  Lines        39845    39844    -1     
========================================
  Hits         25667    25667           
+ Misses       14178    14177    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

phoerious
phoerious reviewed Nov 26, 2025
View reviewed changes
@phoerious
Copy link
Copy Markdown
Member

phoerious commented Nov 26, 2025 •
edited
Loading

Oh, we're having this random test failure again:

FAIL!  : TestTools::testBackupFilePatternSubstitution(Complex custom time pattern) Compared values are not the same
   Actual   (Tools::substituteBackupFilePath(pattern, dbFilePath)): "./25/KeePassXC_20251126_041909.old.kdbx"
   Expected (expectedSubstitution)                                : "./25/KeePassXC_20251126_041908.old.kdbx"

https://ci.keepassxc.org/buildConfiguration/KeePassXC_UbuntuLinux/276042?showLog=276039_1608_1499&logFilter=debug&logView=flowAware

This seems to be happening when the second lapses during the generation of the test pattern matrix and the actual test execution:

keepassxc/tests/TestTools.cpp

Line 157 in 967dc59

QTest::newRow("Complex custom time pattern")

My recommended fix would be simply to remove the second from the pattern. This could still happen at the minute mark, but it's way less likely.

@mikeweilgart mikeweilgart mentioned this pull request Dec 21, 2025
Closed
1 task
@phoerious phoerious merged commit ec034ea into develop Mar 8, 2026
12 checks passed
@phoerious phoerious deleted the fix/autotype-delay branch March 8, 2026 10:58
@phoerious phoerious mentioned this pull request Mar 8, 2026
Merged
20 tasks
@phoerious phoerious added pr: backported Pull request backported to previous release and removed pr:backport-pending Pull request to be backported labels Mar 8, 2026
phoerious pushed a commit that referenced this pull request Mar 8, 2026
@droidmonkey @phoerious
Revert Auto-Type change that caused race condition (#12738)
24f506b 
* Fixes #12723
phoerious pushed a commit that referenced this pull request Mar 8, 2026
@droidmonkey @phoerious
Revert Auto-Type change that caused race condition (#12738)
d06d601 
* Fixes #12723
phoerious pushed a commit that referenced this pull request Mar 8, 2026
@droidmonkey @phoerious
Revert Auto-Type change that caused race condition (#12738)
6baaec2 
* Fixes #12723
pull bot pushed a commit to Andyworldclub/keepassxc that referenced this pull request Mar 8, 2026
@droidmonkey @pull
Revert Auto-Type change that caused race condition (keepassxreboot#12738
4c716d7 
)

* Fixes keepassxreboot#12723
pull bot pushed a commit to byxy77/keepassxc that referenced this pull request Mar 8, 2026
@droidmonkey @pull
Revert Auto-Type change that caused race condition (keepassxreboot#12738
5142b67 
)

* Fixes keepassxreboot#12723
phoerious pushed a commit that referenced this pull request Mar 10, 2026
@droidmonkey @phoerious
Revert Auto-Type change that caused race condition (#12738)
586b895 
* Fixes #12723
@d03j
Copy link
Copy Markdown

d03j commented Mar 13, 2026

confirm this fixed autotype not working on openSUSE KDE X11. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@phoerious phoerious phoerious approved these changes

Assignees

No one assigned

Labels

feature: Auto-Type high priority 🚨 platform: Linux pr: backported Pull request backported to previous release regression

Projects

None yet

Milestone

v2.7.12

Development

Successfully merging this pull request may close these issues.

Auto-Type sometimes does not working after upgrade to 2.7.11

4 participants

@droidmonkey @phoerious @d03j