Improve attachment handling by using a file watcher after you change …#11650
Merged
droidmonkey merged 5 commits intokeepassxreboot:developfrom Feb 1, 2025
Merged
Conversation
Contributor
Author
|
@droidmonkey I fixed the problem that I had found (#11637). To reproduce the issue:
|
Contributor
Author
|
This is a name validation problem, the condition is invalid. |
Member
|
Whoops, that is my fault |
eae8287 to
7062a24
Compare
Member
|
I fixed the logic error and the styling of preview widgets when the main window is not active or disabled |
Contributor
Author
|
I did some refactoring to improve readability. |
Contributor
Author
|
@droidmonkey If you are unsure about the changes, I can do further verification. |
97892d1 to
278acc3
Compare
Member
|
I don't have problems just no time as of late |
…a file and undo that change in the KeePassXC app. This change avoids a situation where the open file has changed or an entry in the application has changed (possibly to be implemented in the future) and when you open that entry the editor shows you outdated data.
* Fixes bug from previous attachments preview commit
278acc3 to
ba07d36
Compare
droidmonkey
approved these changes
Feb 1, 2025
Member
droidmonkey
left a comment
There was a problem hiding this comment.
Good to go, I also put in some logic fixes if there are errors but errorMessage is nullptr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve attachment handling by using a file watcher after you change a file and undo that change in the KeePassXC app
This change avoids a situation where the open file has changed or an entry in the application has changed (possibly to be implemented in the future) and when you open that entry the editor shows you outdated data.
Screenshots
No UI changes
Testing strategy
I didn't find a corresponding test, so I checked manually
Type of change