Add New/Preview Entry Attachments dialog and functionality by w15eacre · Pull Request #11637 · keepassxreboot/keepassxc

w15eacre · 2025-01-07T20:30:45Z

This change adds a new opportunity to add attachments that don’t require a real file in the file system.
Add a new dialog window to add attachments and integrate it into the EntryAttachmentsWidget.
Add an error message if the file name is invalid and disable the save button.
Add the preview button.
Add preview with support for: images and text.

Screenshots

Testing strategy

Manual testing

Type of change

✅ New feature (change that adds functionality)

Closes #3383
Closes #11506

Fixes keepassxreboot#11506

droidmonkey · 2025-01-07T21:50:59Z

Can we pair this with an attachment preview option? Same dialog just in reverse. Can also add an image control on there in case contents are not text.

w15eacre · 2025-01-08T18:30:01Z

@droidmonkey Added text and image preview button.

droidmonkey · 2025-01-08T20:41:27Z

Love it!

Supported types: - text - image Fixes keepassxreboot#11506

w15eacre · 2025-01-09T10:09:07Z

Maybe we should remove the "Preview" button and open supported formats by default in the preview window? And for unsupported formats, add a warning that the file will be decrypted and opened in other software. For an example you can see how it is implemented in classic keepass2.

There is also a bug with the preview window style, you can even see it on the screenshots above. If you open it from the entry, everything is fine, if you open it from the "preview panel", it doesn't follow the style.

I will fix this issue with the style. It's strange, because the same window is shown

w15eacre · 2025-01-09T10:35:43Z

If we replace the "Open" button, then we should be able to edit the file, but I don't understand how to edit non-text files (PDF, images, ...). I want to support preview PDF, because some services save recovery codes in this format.

w15eacre · 2025-01-09T16:37:52Z

@xboxones1 I fixed styles.

I'll check the keepass2 to understand its behavior.

@droidmonkey What do you think about this?

Refactor EntryAttachmentsWidget and PreviewEntryAttachmentsDialog to remove unnecessary parent references Fixes keepassxreboot#11506

droidmonkey · 2025-01-09T18:13:35Z

It works great, although for some reason wouldn't let me preview keeagent.settings which is XML (I think, maybe its Base64).

I think we can make a couple more enhancements. See above for button adds. We can likely get rid of "Rename" by allowing for direct rename within the list widget.

We should create a little grouping in the button list as well:

Fixes keepassxreboot#11506

w15eacre · 2025-01-09T22:31:08Z

Added support for xml, json, yaml, soap, protobuf.

Next time I'll start refactoring the UI

w15eacre · 2025-01-11T00:31:45Z

@droidmonkey I discovered strange behavior:
If I open a file and change it, I discard the changes and close the editor application. I see that the data in the database does not match the open file. If you restart the application, the problem goes away. The whole problem is in re-opening the file, you need to delete it if the name is the same

droidmonkey · 2025-01-11T01:37:25Z

Well, that will need to be fixed 🫣

droidmonkey · 2025-01-11T13:00:54Z

@w15eacre I am moving a couple things around, MimeTypes should be in core/Tools.h/cpp for example. Also trying to avoid use of std::arrays since we are singled up on Qt

droidmonkey · 2025-01-11T15:32:08Z

Done, also made several improvements to the code.

Only one annoying issue remains, if you save an attachment and it does not prompt to overwrite the file, the selection will deselect. I can't see any reason for this in the code, it appears to be a qt bug.

* Reduce multi-selection to single selection when previewing to avoid opening and saving more than the previewed attachment * Don't share EntryAttachments with the preview widget, just pass name/data pair * Reduce number of single-use function calls

w15eacre · 2025-01-11T18:54:40Z

I can't reproduce this problem.
I've finished refactoring the UI.

…uttons on the widget

* Fix sizing of attachment columns * Parent new/preview attachment dialog to widget so it closes properly on database auto-lock * Fix targeting of preview widget styling to not impact unintended children * Add padding to attachment table items

droidmonkey · 2025-01-11T23:33:31Z

I love everything about this, really enhances the attachment experience!

Closes #11506 Closes #3383 * This change adds a new opportunity to add attachments that don’t require a real file in the file system. * Add a new dialog window to add and preview attachments and integrate it into the EntryAttachmentsWidget. * Attachment preview support for images and plain text files. Additional enhancements: * Fix sizing of attachment columns * Add padding to attachment table items * Fix targeting of preview widget styling to not impact unintended children

…eboot#11637) Closes keepassxreboot#11506 Closes keepassxreboot#3383 * This change adds a new opportunity to add attachments that don’t require a real file in the file system. * Add a new dialog window to add and preview attachments and integrate it into the EntryAttachmentsWidget. * Attachment preview support for images and plain text files. Additional enhancements: * Fix sizing of attachment columns * Add padding to attachment table items * Fix targeting of preview widget styling to not impact unintended children

Add New Entry Attachments dialog and functionality

df95ad6

Fixes keepassxreboot#11506

w15eacre force-pushed the feature/add_attachments_new_button branch from eae01f6 to df95ad6 Compare January 7, 2025 20:37

w15eacre force-pushed the feature/add_attachments_new_button branch from 47d1bb0 to abf2159 Compare January 8, 2025 18:26

w15eacre changed the title ~~Add New Entry Attachments dialog and functionality~~ Add New/Preview Entry Attachments dialog and functionality Jan 8, 2025

Add preview functionality for entry attachments

e00aec9

Supported types: - text - image Fixes keepassxreboot#11506

w15eacre force-pushed the feature/add_attachments_new_button branch from abf2159 to e00aec9 Compare January 8, 2025 23:20

droidmonkey added user interface ux pr: new feature Pull request adds a new feature labels Jan 9, 2025

droidmonkey added this to the v2.7.10 milestone Jan 9, 2025

droidmonkey self-requested a review January 9, 2025 18:03

Fix read-only preview

3f91ffe

Refactor EntryAttachmentsWidget and PreviewEntryAttachmentsDialog to remove unnecessary parent references Fixes keepassxreboot#11506

w15eacre force-pushed the feature/add_attachments_new_button branch from 1c1483a to 3f91ffe Compare January 9, 2025 18:10

Enhance attachment type detection with format compatibility checks

2153105

Fixes keepassxreboot#11506

w15eacre marked this pull request as draft January 9, 2025 22:31

Add MimeTypes handling and related tests for attachment previews

deed178

Add Open and Save functionality to attachment preview dialog

c941cda

w15eacre force-pushed the feature/add_attachments_new_button branch from 66e0e43 to c941cda Compare January 11, 2025 00:55

Merge mimetype code into core/Tools.cpp

14db3d5

Improve code for preview widget

23c567e

* Reduce multi-selection to single selection when previewing to avoid opening and saving more than the previewed attachment * Don't share EntryAttachments with the preview widget, just pass name/data pair * Reduce number of single-use function calls

droidmonkey force-pushed the feature/add_attachments_new_button branch from d4edff5 to 23c567e Compare January 11, 2025 16:10

w15eacre marked this pull request as ready for review January 11, 2025 18:54

Refactor attachment widget: remove rename functionality and reorder b…

6feea6a

…uttons on the widget

w15eacre force-pushed the feature/add_attachments_new_button branch from 207a15f to 6feea6a Compare January 11, 2025 20:36

Final cleanup round

3116ded

* Fix sizing of attachment columns * Parent new/preview attachment dialog to widget so it closes properly on database auto-lock * Fix targeting of preview widget styling to not impact unintended children * Add padding to attachment table items

droidmonkey approved these changes Jan 11, 2025

View reviewed changes

droidmonkey merged commit dce34de into keepassxreboot:develop Jan 12, 2025

w15eacre mentioned this pull request Jan 12, 2025

Improve attachment handling by using a file watcher after you change … #11650

Merged

droidmonkey added the pr: backported Pull request backported to previous release label Jan 19, 2025

droidmonkey mentioned this pull request Jan 25, 2025

Store SSH private key in a text field #11696

Closed

1 task

Uh oh!

Conversation

w15eacre commented Jan 7, 2025 • edited by droidmonkey Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Testing strategy

Type of change

Uh oh!

droidmonkey commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w15eacre commented Jan 8, 2025

Uh oh!

droidmonkey commented Jan 8, 2025

Uh oh!

w15eacre commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w15eacre commented Jan 9, 2025

Uh oh!

w15eacre commented Jan 9, 2025

Uh oh!

droidmonkey commented Jan 9, 2025

Uh oh!

w15eacre commented Jan 9, 2025

Uh oh!

w15eacre commented Jan 11, 2025

Uh oh!

droidmonkey commented Jan 11, 2025

Uh oh!

droidmonkey commented Jan 11, 2025

Uh oh!

droidmonkey commented Jan 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

w15eacre commented Jan 11, 2025

Uh oh!

droidmonkey commented Jan 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

w15eacre commented Jan 7, 2025 •

edited by droidmonkey

Loading

droidmonkey commented Jan 7, 2025 •

edited

Loading

w15eacre commented Jan 9, 2025 •

edited

Loading

droidmonkey commented Jan 11, 2025 •

edited

Loading