Fix MacOS login items showing ambigious name#11373
Merged
phoerious merged 1 commit intokeepassxreboot:developfrom Oct 17, 2024
Merged
Fix MacOS login items showing ambigious name#11373phoerious merged 1 commit intokeepassxreboot:developfrom
phoerious merged 1 commit intokeepassxreboot:developfrom
Conversation
Member
|
Sweet! |
droidmonkey
approved these changes
Oct 16, 2024
phoerious
approved these changes
Oct 17, 2024
|
Coming from the closed thread #8818 JFYI this is still happening on macOs Sequoia
|
Member
|
This isn't in a release yet |
|
That makes sense, I didn't check the last release date or if this was in it. Thanks! |
droidmonkey
pushed a commit
that referenced
this pull request
Dec 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8818.
Adding the
AssociatedBundleIdentifiersplist property mentioned by user @nodeful fixes the issue of an ambigious (to most users) name appearing in their login items menu on MacOS.Documentation relating to this property can be found here: https://developer.apple.com/documentation/servicemanagement/updating-helper-executables-from-earlier-versions-of-macos#Connect-services-to-app-names-in-System-Settings
Additionally we also add the
Programproperty using the full path of the application bundle, this seems to further prevent the "organisation name" (from the certificate signing) from appearing in the login items screen. Without this extra change Janek Bevendorff's name would still appear after a delayScreenshots
Before change:
After change:
Testing strategy
Manually editing the installed launchd.plist file
org.keepassxc.KeePassXC.plistin~/Library/LaunchAgents. I couldn't get the latest KeePassXC develop commit to build on my local machine.Type of change