Skip to content

Add option to disable opening a browser window when double-clicking the "URL" column in EntryView.cpp#11332

Merged
droidmonkey merged 2 commits intokeepassxreboot:developfrom
libklein:feature/disable-double-click-on-url
Oct 9, 2024
Merged

Add option to disable opening a browser window when double-clicking the "URL" column in EntryView.cpp#11332
droidmonkey merged 2 commits intokeepassxreboot:developfrom
libklein:feature/disable-double-click-on-url

Conversation

@libklein
Copy link
Copy Markdown
Contributor

@libklein libklein commented Oct 8, 2024

This pull request introduces a new configuration option, OpenURLOnDoubleClick, which allows users to open URLs by double-clicking on the "URL" column.
This changes the behavior as follows:

  • Double-clicking the "URL" column of an entry will open a new browser window unless explicitly configured not to.
  • In this case, double-clicking defaults to the "default" action (i.e., editing).
  • Also changed the double-clicking behavior when no URL is configured. This previously did nothing, but now falls back to editing the entry - regardless of whether the new setting is enabled or not.

The setting can be configured in the "General" tab:
image

Fixes: #11327

Testing strategy

Tested locally.

Type of change

  • ✅ New feature (change that adds functionality)

@droidmonkey
Copy link
Copy Markdown
Member

droidmonkey commented Oct 8, 2024 •
edited
Loading

Please move the setting up a couple spots right under the "double click field" setting and use the wording: "Open browser on double clicking URL field in entry view"

Also fix the tab ordering

@libklein
Copy link
Copy Markdown
Contributor Author

libklein commented Oct 8, 2024

Please move the setting up a couple spots right under the "double click field" setting and use the wording: "Open browser on double clicking URL field in entry view"

Done.

Also fix the tab ordering

Sorry, the tab ordering? What are you referring to?

@droidmonkey droidmonkey self-requested a review October 8, 2024 23:29
@droidmonkey droidmonkey added this to the v2.7.10 milestone Oct 8, 2024
@droidmonkey
Copy link
Copy Markdown
Member

droidmonkey commented Oct 8, 2024

Just for reference:

image

I fixed it for you and updated translations

@droidmonkey droidmonkey force-pushed the feature/disable-double-click-on-url branch from e97ea50 to 9642ea2 Compare October 8, 2024 23:33
@droidmonkey droidmonkey merged commit 740994e into keepassxreboot:develop Oct 9, 2024
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Oct 12, 2024
droidmonkey added a commit that referenced this pull request Oct 12, 2024
@droidmonkey
Add option to disable opening a browser window when double-clicking t…
06699c6 
…he "URL" column (#11332)
@phoerious phoerious added pr: new feature Pull request adds a new feature and removed new feature labels Nov 22, 2024
pull bot pushed a commit to Graysonbarton/keepassxc that referenced this pull request Jan 26, 2025
@libklein @pull
Add option to disable opening a browser window when double-clicking t…
9082c73 
…he "URL" column (keepassxreboot#11332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees

No one assigned

Labels

pr: backported Pull request backported to previous release pr: new feature Pull request adds a new feature user interface

Projects

None yet

Milestone

v2.7.10

Development

Successfully merging this pull request may close these issues.

Add option to disable opening URL on double click

3 participants

@libklein @droidmonkey @phoerious