Skip to content

Implement function to clear all ssh-agent identities#10649

Merged
droidmonkey merged 4 commits intokeepassxreboot:developfrom
AlexpFr:feature/sshAgent-ssh-add-D
Feb 1, 2025
Merged

Implement function to clear all ssh-agent identities#10649
droidmonkey merged 4 commits intokeepassxreboot:developfrom
AlexpFr:feature/sshAgent-ssh-add-D

Conversation

@AlexpFr
Copy link
Copy Markdown
Contributor

@AlexpFr AlexpFr commented May 1, 2024

Implement a function that replicates the behavior of the ssh-add -D command.

image

Testing strategy

Tested manually and compare result to the real ssh-add -D command.
Ensure that the Tools menu item is hidden when the SSH agent is disabled or when -DWITH_XC_SSHAGENT=OFF.

Type of change

  • ✅ New feature (change that adds functionality)

@AlexpFr AlexpFr changed the title Feature/ssh agent ssh add d Implement function to clear all ssh-agent identities May 1, 2024
@AlexpFr AlexpFr force-pushed the feature/sshAgent-ssh-add-D branch 4 times, most recently from 5d43dba to d38d502 Compare May 7, 2024 19:07
@AlexpFr
Copy link
Copy Markdown
Contributor Author

AlexpFr commented May 25, 2024

Hello, is this PR ready for a merge? Do I need to review certain points?
Thanks.

@droidmonkey
Copy link
Copy Markdown
Member

Will review when I get the chance

@AlexpFr AlexpFr force-pushed the feature/sshAgent-ssh-add-D branch from d38d502 to f232411 Compare June 23, 2024 20:43
@droidmonkey droidmonkey requested a review from hifi June 23, 2024 20:49
@AlexpFr AlexpFr force-pushed the feature/sshAgent-ssh-add-D branch from f232411 to ee37774 Compare June 23, 2024 20:54
@AlexpFr
Copy link
Copy Markdown
Contributor Author

AlexpFr commented Jun 23, 2024

Remember note:

Openssh-portable upstream code relative to ssh-add -D:

@AlexpFr AlexpFr force-pushed the feature/sshAgent-ssh-add-D branch from ee37774 to ba7b42f Compare June 30, 2024 09:23
@droidmonkey droidmonkey modified the milestones: v2.8.0, v2.7.10 Aug 19, 2024
@phoerious phoerious added pr: new feature Pull request adds a new feature and removed new feature labels Nov 22, 2024
@droidmonkey droidmonkey force-pushed the feature/sshAgent-ssh-add-D branch from ba7b42f to a287dee Compare January 26, 2025 15:39
@droidmonkey droidmonkey merged commit 15ac8ac into keepassxreboot:develop Feb 1, 2025
pull bot pushed a commit to Graysonbarton/keepassxc that referenced this pull request Feb 1, 2025
…10649)

Fixes keepassxreboot#8346

---------

Co-authored-by: Jonathan White <support@dmapps.us>
droidmonkey added a commit that referenced this pull request Feb 2, 2025
Fixes #8346

---------

Co-authored-by: Jonathan White <support@dmapps.us>
@droidmonkey droidmonkey added the pr: backported Pull request backported to previous release label Feb 2, 2025
pull bot pushed a commit to blog2i2j/keepassxreboot.._..keepassxc that referenced this pull request Feb 22, 2025
…10649)

Fixes keepassxreboot#8346

---------

Co-authored-by: Jonathan White <support@dmapps.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: SSH agent pr: backported Pull request backported to previous release pr: new feature Pull request adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all keepass ssh keys without locking db

3 participants