update header file for Qt5#1
Merged
droidmonkey merged 1 commit intokeepassxreboot:masterfrom Mar 15, 2016
Merged
Conversation
droidmonkey
added a commit
that referenced
this pull request
Mar 15, 2016
update header file for Qt5
Closed
This was referenced Apr 6, 2017
weslly
pushed a commit
that referenced
this pull request
Nov 30, 2017
…s-placeholders Implement resolving for references placeholders
Closed
Closed
Closed
This was referenced Jan 17, 2019
This was referenced Mar 21, 2019
Closed
Closed
Closed
1 task
1 task
1 task
1 task
sebastianlivoni
added a commit
to sebastianlivoni/keepassxc
that referenced
this pull request
Jun 7, 2025
…9f734c..7943959d7 7943959d7 Merge pull request keepassxreboot#1 from sebastianlivoni/develop 42ba9be92 Merge branch 'feature/safari' into develop 003feb7c5 Merge pull request keepassxreboot#2571 from keepassxreboot/fix/check_input_width_with_segmented_totp 633fd4bf0 Merge pull request keepassxreboot#2574 from keepassxreboot/fix/atlassian_password_input 606e35762 Fix detecting Atlassian password input eb9285212 Fix checking input width with segmented TOTP fields dac9cecef Merge pull request keepassxreboot#2566 from keepassxreboot/fix/query_form_on_savedform_check 6b427faf3 Query form on savedForms check 54f5fe616 Merge pull request keepassxreboot#2560 from keepassxreboot/fix/update_issue_template cda5ee592 Merge pull request keepassxreboot#2553 from keepassxreboot/fix/styling_improvements 8c42d7fce Add some more space between options 2c639749c Styling improvements 951557d50 Merge pull request keepassxreboot#2548 from joetor5/html-id 4be2b176c Fix browser integration doc link id 86c17bf04 Merge pull request keepassxreboot#2542 from keepassxreboot/fix/chatgpt_submit_button 8e4b866f4 Add submit button exception for OpenAI login page a2748198b Merge pull request keepassxreboot#2525 from keepassxreboot/fix/credential_banner_improvement 064d27bf0 Improve username input detection with Credential Banner dccf307e0 Merge pull request keepassxreboot#2524 from keepassxreboot/feature/add_support_for_firefox_shortcuts_page c282d11ac Add support for opening Firefox shortcut settings page 5a6d37acf Merge pull request keepassxreboot#2523 from keepassxreboot/fix/get_credentials_from_different_db 7839dfe09 Fix retrieving credentials from changed DB in unlock dialog 25e1b2745 Merge pull request keepassxreboot#2522 from keepassxreboot/update_to_198 2bf48c680 Update to 1.9.8 0de621f0d Merge pull request keepassxreboot#2510 from keepassxreboot/fix/page_id_checks d5063a6cf Fixes for page object checks and context menu item creation a8297aeb5 Merge pull request keepassxreboot#2500 from keepassxreboot/fix/disable_passkeys_if_site_is_ignored a5e7444f3 Merge pull request keepassxreboot#2521 from keepassxreboot/feature/support_autocomplete_username f19c90cc0 Add support for autocomplete=username e11d63df5 Disable passkeys script injection if site is ignored git-subtree-dir: src/safariwebextension/keepassxc-browser git-subtree-split: 7943959d7bb61a900f900b0a633778ea2acefa83
1 task
1 task
1 task
This was referenced Mar 26, 2026
1 task
ThongvanAlexis
added a commit
to ThongvanAlexis/keepassxc
that referenced
this pull request
May 3, 2026
…semantics (RED) NXAUTH-01 (complete) + NXAUTH-02 + NXAUTH-03 + NXAUTH-05 surface coverage: Task 1: 14 polling-state-machine tests - testPollingSuccessEmitsLoginCompletedWithCredentials (200+full keys -> loginCompleted) - testPolling200MissingAppPasswordFailsWithLockedBanner (Pitfall 5: missing key) - testPolling200EmptyAppPasswordFailsWithLockedBanner (Pitfall 5: empty value) - testPolling303ContinuesPolling (3xx surface) - testPolling404ContinuesPolling (404 surface; nextcloud-desktop flow2auth.cpp:281 alignment) - testPolling410ContinuesPolling (410 surface; CONTEXT.md spec lock) - testPolling401HardFailsAndStops (banner keepassxreboot#4) - testPolling500HardFailsAndStops (banner keepassxreboot#4) - testPollingNetworkErrorFailsWithLockedBanner (banner keepassxreboot#4) - testPollingTimeoutFiresLockedBanner (banner keepassxreboot#1; sub-second wall-clock via test seam) - testPollingTickFiresAtConfiguredInterval (repeating QTimer cadence) - testPollingRequestUsesManualRedirectPolicy (RESEARCH Pitfall 4: per-request) - testPollingRequestUserAgentSet (NXAUTH-07 carryover to poll path) - testPollingRequestSendsTokenInBody (token=<urlencoded m_pollToken>) Task 2: 3 cancel-semantics tests (NXAUTH-05) - testStartLoginFlowCancelsPreviousFlow (cancel-previous; loginCancelled count == 1) - testDoubleAuthorizeNoConcurrentPolling (no two cadences simultaneously) - testExplicitCancelStopsActiveFlow (widget-driven cancel tear-down) Helpers: makePollSuccessReply (server/loginName/appPassword JSON shape), makePollStatusReply (status-only no-body 3xx/4xx/5xx replies). All polling tests use setPollIntervalMsForTest(10) + setTimeoutMsForTest(50..500) to keep wall-clock under 1 second per test while still exercising the production state machine end-to-end. These tests are RED at this commit -- the polling state machine production code lands in the next commit (GREEN). Mirrors Plan 11-01 decision keepassxreboot#3 (TDD discipline at the 2-commit-per-plan grain rather than per-test grain). Per CLAUDE.md the local ctest gate is deferred to phase-end (Plan 11-05); 4-platform CI is the binding verification for this branch.
ThongvanAlexis
added a commit
to ThongvanAlexis/keepassxc
that referenced
this pull request
May 3, 2026
NXAUTH-01 (complete) + NXAUTH-02 + NXAUTH-03 + NXAUTH-05.
NextcloudLoginFlow.h additions:
- 3 private slots: onPollTick / onPollFinished / onPollTimeoutFired
- 2 private helpers: startPolling / stopPollingTimers
- 1 private member: m_pollElapsedSec (tick counter; not wall-clock)
NextcloudLoginFlow.cpp additions:
- File-scope BANNER_1_TIMEOUT + BANNER_4_NETWORK_ERROR constants verbatim
from CONTEXT.md (banner keepassxreboot#1: "Nextcloud authorization timed out. Click
Authorize to try again." / banner keepassxreboot#4: "Lost connection to Nextcloud
during authorization. Click Authorize to try again.")
- Constructor wires m_pollTimer (repeating) -> onPollTick and m_timeoutTimer
(single-shot) -> onPollTimeoutFired
- cancel() body: full RESEARCH Pitfall 6 thread-safe abort mirroring
NextcloudSyncProvider::abort verbatim shape (timers stop -> mutex-guarded
QMetaObject::invokeMethod abort QueuedConnection -> state transition +
loginCancelled emit only if state was not already Idle)
- onInitiateFinished now invokes startPolling() after host validation
passes (replaces the Plan 11-01 TODO marker)
- startPolling: sets state Polling, resets interval, starts both timers,
fires onPollTick once immediately so user does not wait one full interval
- onPollTick: emits pollingTick(elapsedSec, totalSec) BEFORE the request
POST (UX: spinner update lag-free), composes poll request with User-Agent
KeePassXC/<version> + Content-Type form-urlencoded + ManualRedirectPolicy
per-request (RESEARCH Pitfall 4), POSTs token=<urlencoded m_pollToken>,
stores reply under m_replyMutex, bumps m_pollElapsedSec
- onPollFinished: full status-surface dispatch per RESEARCH.md table:
OperationCanceledError -> silent absorb (cancel path already emitted)
Network error (non-canceled, no HTTP status) -> banner keepassxreboot#4
3xx (300-399) / 404 / 410 -> continue polling (no signal)
200 + valid body (server + loginName + appPassword all non-empty) ->
loginCompleted(loginName, appPassword) + stop timers
200 + parse error / missing key / empty value -> banner keepassxreboot#4 + stop
(RESEARCH Pitfall 5: server defects surfaced as network error)
401 / 403 / any 5xx / any other 4xx -> banner keepassxreboot#4 + stop
- onPollTimeoutFired: stop timers + banner keepassxreboot#1 (NXAUTH-02)
- stopPollingTimers: idempotent helper used by all terminal branches +
cancel(); stops both timers and clears m_activeReply under m_replyMutex
- startLoginFlow opening comment updated: cancel() at top is the NXAUTH-05
invariant, no longer a Plan-11-02-future-work marker
Forward-prep grep gates clean (Phase 12 NAV-03):
- zero qDebug|qWarning in NextcloudLoginFlow.cpp
- zero ignoreSslErrors in NextcloudLoginFlow.cpp
- zero NextcloudLoginFlow|LoginFlow in 5 generic-infrastructure files
(SyncEngine.cpp / RemoteSettings.cpp / DatabaseWidget.cpp /
MainWindow.cpp / DatabaseSettingsWidgetCloudSync.cpp)
- 4 banner verbatim strings present in NextcloudLoginFlow.cpp
- tr(BANNER_1) + tr(BANNER_4) call sites: 5 hits (1 timeout + 4 network)
- ManualRedirectPolicy: 2 attribute setters (initiate Plan 11-01 + poll
Plan 11-02) + 1 explanatory comment
- QMetaObject::invokeMethod abort QueuedConnection: 1 hit (cancel)
- m_pollTimer->start(): 1 hit (startPolling)
- m_timeoutTimer->start(m_pollTimeoutMs): 1 hit (startPolling)
testnextcloudloginflow grew 10 -> 27 methods; +17 cumulative for Plan 11-02
(14 polling + 3 cancel-semantics from RED commit b79fdbe now flip GREEN).
Per CLAUDE.md the local ctest gate is deferred to phase-end (Plan 11-05);
4-platform CI is the binding verification for this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header file for QMessageBox has been moved from "QtGui" to "QtWidgets"