This repository was archived by the owner on Dec 9, 2021. It is now read-only.
Implemented unlock dialog for auto type (bug #197)#99
Closed
sevanteri wants to merge 9 commits intokeepassx:masterfrom
Closed
Implemented unlock dialog for auto type (bug #197)#99sevanteri wants to merge 9 commits intokeepassx:masterfrom
sevanteri wants to merge 9 commits intokeepassx:masterfrom
Conversation
Author
|
Travis seems to fail because of the GUI additions. |
64ce626 to
9745565
Compare
src/gui/DatabaseTabWidget.cpp
Outdated
Member
There was a problem hiding this comment.
Will be very unhappy if there is no database tab.
You'll want to iterate over the databases and show the dialog for the first database that is actually locked.
Member
|
UnlockDatabaseDialog should be closed once the database has been unlocked or closed from the main window. |
Dialog now closed when database closed from main window.
Author
|
Right'o. Currently auto type is performed on all of the unlocked databases. If all of the databases are locked, then a dialog is shown for the first tab. And I just realized there is no point iterating the tabs if all of them are locked. Useless for loop there... |
andrewcchen
pushed a commit
to andrewcchen/keepassx
that referenced
this pull request
May 6, 2016
for auto type See pull request keepassx#99 for original
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented a dialog for unlocking the first database tab when all databases are locked and the autotype hotkey is pressed.
Link to the issue: https://www.keepassx.org/dev/issues/197