This repository was archived by the owner on Dec 9, 2021. It is now read-only.
Add sortable last-modified column to entry list view#192
Open
jonhnet wants to merge 1 commit intokeepassx:masterfrom
Open
Add sortable last-modified column to entry list view#192jonhnet wants to merge 1 commit intokeepassx:masterfrom
jonhnet wants to merge 1 commit intokeepassx:masterfrom
Conversation
|
Looks like a test needs to be updated to reflect the added column: |
Thynix
reviewed
Jan 1, 2017
| Username = 2, | ||
| Url = 3 | ||
| Url = 3, | ||
| LastModified = 4 |
There was a problem hiding this comment.
Thoughts on ending LastModified with a trailing comma so that additional columns need not modify the previous last column as you have had to do here?
Thynix
reviewed
Jan 1, 2017
| { | ||
| // Surely there's a way to ask for sort-by-object and convert to string | ||
| // later, by giving this item a non-string model. But I'm going to do | ||
| // a simpler thing for now, to avoid having to learn Qt. |
There was a problem hiding this comment.
Perhaps specify the reasoning explicitly:
a simpler the for now - format the date as one that sorts
alphabetically by datetime - to avoid having to learn Qt.
|
Other than the test failure the only suggestions I have are minor. |
daniellandau
pushed a commit
to daniellandau/keepassx
that referenced
this pull request
Feb 9, 2017
…rd-generator-button-padding Use consistent button min-heights, resolves keepassx#192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior versions of keepassx had the ability to sort entries by last-modified time. I synchronize my keepass db to multiple devices with svn; this feature is invaluable for handling accidental conflicts. This patch reintroduces the last-modified column.