Conversation
Signed-off-by: Aniruddh Chaturvedi <aniruddhchaturvedi@gmail.com>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
|
The question here is, do we change the documentation, or do we change the name of the scaler? All scalers end with '_scaler'. So I personally advocate harmonizing this and therefore changing the file name in Of course, I don't decide this alone, so I'm curious to hear the opinion of a maintainer or an other KEDA Reviewer. |
That's a really interesting point, I'd rename the scaler file too to align with other scalers |
|
Hi @aniruddhc1! Thanks for this PR! Great find! Is it possible for you to rename the files in keda? This concerns both, temporal.go and temporal_test.go |
|
Happy to! |
The temporal scaler name is temporal.go, not temporal_scaler.go
This updates version 2.18
I have another PR for version 2.17 (#1573)
Checklist
Fixes #