Skip to content

Update temporal.md#1574

Closed
aniruddhc1 wants to merge 1 commit intokedacore:mainfrom
aniruddhc1:patch-3
Closed

Update temporal.md#1574
aniruddhc1 wants to merge 1 commit intokedacore:mainfrom
aniruddhc1:patch-3

Conversation

@aniruddhc1
Copy link

@aniruddhc1 aniruddhc1 commented Jun 3, 2025

The temporal scaler name is temporal.go, not temporal_scaler.go
This updates version 2.18
I have another PR for version 2.17 (#1573)

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

Signed-off-by: Aniruddh Chaturvedi <aniruddhchaturvedi@gmail.com>
@aniruddhc1 aniruddhc1 requested a review from a team as a code owner June 3, 2025 04:19
@netlify
Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 33d27ce
🔍 Latest deploy log https://app.netlify.com/projects/keda/deploys/683e77f0e0503100086b0225
😎 Deploy Preview https://deploy-preview-1574--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@aniruddhc1 aniruddhc1 mentioned this pull request Jun 3, 2025
1 task
@rickbrouwer
Copy link
Member

The question here is, do we change the documentation, or do we change the name of the scaler? All scalers end with '_scaler'. So I personally advocate harmonizing this and therefore changing the file name in keda.

Of course, I don't decide this alone, so I'm curious to hear the opinion of a maintainer or an other KEDA Reviewer.

@JorTurFer
Copy link
Member

The question here is, do we change the documentation, or do we change the name of the scaler? All scalers end with '_scaler'. So I personally advocate harmonizing this and therefore changing the file name in keda.

That's a really interesting point, I'd rename the scaler file too to align with other scalers

@rickbrouwer
Copy link
Member

Hi @aniruddhc1!

Thanks for this PR! Great find! Is it possible for you to rename the files in keda?

This concerns both, temporal.go and temporal_test.go

#1573 and #1574 may then be closed

@aniruddhc1
Copy link
Author

Happy to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants