Add vhostName to Auth Params RabbitMQ doc#1525
Merged
JorTurFer merged 1 commit intokedacore:mainfrom Feb 3, 2025
Merged
Conversation
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
Contributor
Author
|
Hmm. I think the CI linting check has been failing for some times ( I glanced at the last few PRs and all has the same failure ). Is it something that we have to fix before we merge @JorTurFer ? |
JorTurFer
reviewed
Jan 22, 2025
JorTurFer
approved these changes
Feb 3, 2025
Member
|
@dttung2905 , please update DCO |
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
auto-merge was automatically disabled
February 3, 2025 22:47
Head branch was pushed to by a user without write access
1a08f4a to
1d941a8
Compare
Contributor
Author
|
@JorTurFer Thanks Jorge. I have fixed the DCO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the doc to show how
vhostNamecan be added to auth Params referencing a secretChecklist
Fixes kedacore/keda#6373