Skip to content

Use RabbitMQ vhostName from authParams when declared#6373

Merged
JorTurFer merged 4 commits intokedacore:mainfrom
michemache:trigger-authentication-vhost-name
Feb 3, 2025
Merged

Use RabbitMQ vhostName from authParams when declared#6373
JorTurFer merged 4 commits intokedacore:mainfrom
michemache:trigger-authentication-vhost-name

Conversation

@michemache
Copy link
Contributor

@michemache michemache commented Nov 28, 2024

If the RabbitMQ vhostName is declared in the TriggerAuthentication resource, it will be used.

Checklist

Fixes #6369

Signed-off-by: Michi U. <4169888+michemache@users.noreply.github.com>
@michemache michemache force-pushed the trigger-authentication-vhost-name branch from f908127 to 977de43 Compare November 28, 2024 11:05
Signed-off-by: Michi U. <4169888+michemache@users.noreply.github.com>
@michemache michemache force-pushed the trigger-authentication-vhost-name branch from 252008a to 83d9508 Compare November 28, 2024 11:17
@michemache michemache marked this pull request as ready for review November 28, 2024 11:36
@michemache michemache requested a review from a team as a code owner November 28, 2024 11:36
@zroubalik
Copy link
Member

zroubalik commented Dec 4, 2024

/run-e2e rabbitmq
Update: You can check the progress here

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs missing

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update docs

@dttung2905
Copy link
Contributor

I have made related update in the doc in this PR kedacore/keda-docs#1525 . @zroubalik @JorTurFer could you help to take a look please 🙏 ?

Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member

JorTurFer commented Jan 22, 2025

/run-e2e rabbit
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 459a178 into kedacore:main Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support parameter vhostName in TriggerAuthentication

4 participants