Skip to content

Announce removal of deprecated variable in CPU Memory Scaler#1484

Merged
wozniakjan merged 1 commit intokedacore:mainfrom
rickbrouwer:cpu
Oct 22, 2024
Merged

Announce removal of deprecated variable in CPU Memory Scaler#1484
wozniakjan merged 1 commit intokedacore:mainfrom
rickbrouwer:cpu

Conversation

@rickbrouwer
Copy link
Member

@rickbrouwer rickbrouwer commented Oct 11, 2024

The parameter type is already from release 2.7 deprecated. I think it's time to announce the removal and remove the deprecated code in version 2.18.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related kedacore/keda#6229

Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
@rickbrouwer rickbrouwer requested a review from a team as a code owner October 11, 2024 18:04
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit d71e0f1
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/670968c003a1fa000804859c
😎 Deploy Preview https://deploy-preview-1484--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan merged commit 5ca17f3 into kedacore:main Oct 22, 2024
@rickbrouwer rickbrouwer deleted the cpu branch November 17, 2024 12:36
CharlesB2 added a commit to CharlesB2/keda-docs that referenced this pull request Oct 14, 2025
The code was updated a while ago after kedacore#1484 but the docs change wasn't complete

Signed-off-by: Charles Brossollet <charles.brossollet@gitguardian.com>
CharlesB2 added a commit to CharlesB2/keda-docs that referenced this pull request Oct 14, 2025
The code was updated a while ago after kedacore#1484 but the docs change wasn't complete

Signed-off-by: Charles Brossollet <charles.brossollet@gitguardian.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants