Skip to content

Document prometheus metric deprecations#1374

Merged
zroubalik merged 3 commits intokedacore:mainfrom
wozniakjan:prometheus_metric_refactor
Apr 19, 2024
Merged

Document prometheus metric deprecations#1374
zroubalik merged 3 commits intokedacore:mainfrom
wozniakjan:prometheus_metric_refactor

Conversation

@wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented Apr 16, 2024 •
edited
Loading

Original work in #1258, reasons for duplicate PR kedacore/keda#5687 (comment)

Updates the docs with the changes in kedacore/keda#5174.

I merely cherry-picked the documentation changes and applied review suggestions

  • moved the docs to target 2.14
  • fixed minor typos
  • also kept original text next to the deprecated metrics right after the deprecation notice and recommendation to use new metric

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

closes: #1258

@wonko @wozniakjan
Document prometheus metric deprecations
e20a4c1 
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan requested a review from a team as a code owner April 16, 2024 08:04
@github-actions
Copy link

github-actions bot commented Apr 16, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify
Copy link

netlify bot commented Apr 16, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit c8d0835
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66210b2dda22a20008f7e551
😎 Deploy Preview https://deploy-preview-1374--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wozniakjan wozniakjan mentioned this pull request Apr 16, 2024
Merged
4 tasks
tomkerkhove
tomkerkhove approved these changes Apr 18, 2024
View reviewed changes
wozniakjan and others added 2 commits April 18, 2024 13:56
@wozniakjan @tomkerkhove
Update content/docs/2.14/operate/prometheus.md
b7976f6 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan
swap information order on deprecated prometheus metrics
c8d0835 
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan
Copy link
Member Author

wozniakjan commented Apr 19, 2024

thanks @tomkerkhove, I applied your suggestions, let me please know if there is anything else.

@zroubalik zroubalik merged commit 15efec1 into kedacore:main Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zroubalik zroubalik zroubalik approved these changes

+1 more reviewer

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wozniakjan @zroubalik @tomkerkhove @wonko