Closed
Conversation
Signed-off-by: Bernard Grymonpon <bernard@grymonpon.be>
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
4 tasks
zroubalik
reviewed
Feb 12, 2024
Member
zroubalik
left a comment
There was a problem hiding this comment.
can we please update this to target 2.14?
4 tasks
wozniakjan
reviewed
Apr 12, 2024
| - `keda_scaler_errors_total` - The unlabeled version is deprecated. Sum the `keda_scaler_errors_total`. | ||
| - `keda_scaler_errors` - Replaced by `keda_scaler_errors_total` (labeled). | ||
| - `keda_scaler_metrics_latency` - Replaced by `keda_scaler_metrics_latency_seconds`. | ||
| - `keda_trigger_totals` - Replaced by `trigger_handled_total`. |
Member
There was a problem hiding this comment.
nit:
Suggested change
| - `keda_trigger_totals` - Replaced by `trigger_handled_total`. | |
| - `keda_trigger_totals` - Replaced by `keda_trigger_handled_total`. |
| - `keda_scaled_object_errors_total` - The number of errors that have occurred for each ScaledObject. | ||
| - `keda_scaled_object_paused` - This metric indicates whether a ScaledObject is paused (value == 1) or un-paused (value == 0). | ||
| - `keda_scaler_active` - This metric marks whether the particular scaler is active (value == 1) or in-active (value == 0). | ||
| - `keda_scaler_errors_total` - The total number of errors encountered for each scaler. |
Member
There was a problem hiding this comment.
the keda_scaler_errors_total existed before, I'd suggest keda_scaler_detail_errors_total instead kedacore/keda#5687 (comment)
Suggested change
| - `keda_scaler_errors_total` - The total number of errors encountered for each scaler. | |
| - `keda_scaler_detail_errors_total` - The total number of errors encountered for each scaler. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the docs with the changes in kedacore/keda#5174. Should be merged if the PR is accepted, or adapted as needed.
Checklist