Skip to content

fix: create new HTTP request for each queue query in IBMMQ scaler#7202

Merged
wozniakjan merged 1 commit intokedacore:mainfrom
rickbrouwer:ibmmq
Oct 27, 2025
Merged

fix: create new HTTP request for each queue query in IBMMQ scaler#7202
wozniakjan merged 1 commit intokedacore:mainfrom
rickbrouwer:ibmmq

Conversation

@rickbrouwer
Copy link
Member

@rickbrouwer rickbrouwer commented Oct 27, 2025

Refactor IBM MQ scaler HTTP request handling.
Each queue now uses a new http.Request instance instead of reusing a single request with modified bodies.

Checklist

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 27, 2025 07:32
@keda-automation keda-automation requested a review from a team October 27, 2025 07:32
@github-actions
Copy link

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@rickbrouwer
Copy link
Member Author

rickbrouwer commented Oct 27, 2025

/run-e2e ibm
Update: You can check the progress here

@rickbrouwer rickbrouwer mentioned this pull request Oct 27, 2025
28 tasks
@JorTurFer
Copy link
Member

I'm curious about why this is needed. Does it mix the requests?

@rickbrouwer
Copy link
Member Author

Not that I know of, but the original code reuses a single http.Request instance across multiple queue queries by only replacing the req.Body in each loop iteration. Creating a new request for each iteration ensures proper isolation and prevents potential issues with request state management.

@wozniakjan wozniakjan merged commit 5eb21e3 into kedacore:main Oct 27, 2025
24 checks passed
@rickbrouwer rickbrouwer deleted the ibmmq branch October 27, 2025 17:06
rickbrouwer added a commit to rickbrouwer/keda that referenced this pull request Oct 28, 2025
alt-dima pushed a commit to alt-dima/keda that referenced this pull request Dec 13, 2025
…dacore#7202)

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants