Skip to content

Refactor graphite scaler#7185

Merged
JorTurFer merged 4 commits intokedacore:mainfrom
dttung2905:refactor-graphite-scaler
Oct 26, 2025
Merged

Refactor graphite scaler#7185
JorTurFer merged 4 commits intokedacore:mainfrom
dttung2905:refactor-graphite-scaler

Conversation

@dttung2905
Copy link
Contributor

Refactor graphite scalers. We only have a few scalers left to be refactored

Checklist

Relates to #5797

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905 dttung2905 requested a review from a team as a code owner October 16, 2025 21:09
@github-actions
Copy link

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@keda-automation keda-automation requested a review from a team October 18, 2025 21:05
@rickbrouwer
Copy link
Member

Please run 'make generate-scalers-schema'

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@rickbrouwer
Copy link
Member

rickbrouwer commented Oct 19, 2025

/run-e2e graphite
Update: You can check the progress here

@rickbrouwer
Copy link
Member

rickbrouwer commented Oct 19, 2025

There is an unmatched property.

ERROR typed_config Unmatched input property metricName in scaler graphite

Can you also fix that (remove this line)?

Thanks!

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905
Copy link
Contributor Author

dttung2905 commented Oct 26, 2025

/run-e2e graphite
Update: You can check the progress here

@JorTurFer JorTurFer merged commit f3ee90e into kedacore:main Oct 26, 2025
24 checks passed
alt-dima pushed a commit to alt-dima/keda that referenced this pull request Dec 13, 2025
* Refactor graphite scaler

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

* Fixes from codereview

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

* Generate new schema

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

* remove redundant line

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

---------

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025
* Refactor graphite scaler

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

* Fixes from codereview

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

* Generate new schema

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

* remove redundant line

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

---------

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026
* Refactor graphite scaler

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

* Fixes from codereview

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

* Generate new schema

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

* remove redundant line

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>

---------

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants