Allow setting Temporal's targetQueueSize to 0.#7113
Merged
zroubalik merged 2 commits intokedacore:mainfrom Sep 30, 2025
Merged
Conversation
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
0 is a valid setting, no need to require >= 1. Signed-off-by: Rob Holland <rob@temporal.io>
7c5b267 to
47fe896
Compare
Signed-off-by: Rob Holland <rob@temporal.io>
|
appreciate the quick response to this 💪 |
Member
|
/run-e2e temporal |
rickbrouwer
approved these changes
Sep 29, 2025
Member
wozniakjan
approved these changes
Sep 30, 2025
zroubalik
approved these changes
Sep 30, 2025
alt-dima
pushed a commit
to alt-dima/keda
that referenced
this pull request
Dec 13, 2025
* Allow setting targetQueueSize to 0. 0 is a valid setting, no need to require >= 1. Signed-off-by: Rob Holland <rob@temporal.io> * Revert accidental whitespace change. Signed-off-by: Rob Holland <rob@temporal.io> --------- Signed-off-by: Rob Holland <rob@temporal.io> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
tangobango5
pushed a commit
to tangobango5/keda
that referenced
this pull request
Dec 22, 2025
* Allow setting targetQueueSize to 0. 0 is a valid setting, no need to require >= 1. Signed-off-by: Rob Holland <rob@temporal.io> * Revert accidental whitespace change. Signed-off-by: Rob Holland <rob@temporal.io> --------- Signed-off-by: Rob Holland <rob@temporal.io>
tangobango5
pushed a commit
to tangobango5/keda
that referenced
this pull request
Feb 13, 2026
* Allow setting targetQueueSize to 0. 0 is a valid setting, no need to require >= 1. Signed-off-by: Rob Holland <rob@temporal.io> * Revert accidental whitespace change. Signed-off-by: Rob Holland <rob@temporal.io> --------- Signed-off-by: Rob Holland <rob@temporal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0 is a valid setting, no reason to require >=.
Checklist
No docs changes required as the behaviour of the setting is still the same.
Fixes #
Relates to #