feat(azure_pipelines_scaler): add an option to enable demands to be case insensitive#7112
Conversation
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
|
Semgrep found 1 Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'. |
db4d8cf to
dbd5537
Compare
a3822cc to
8cf2d26
Compare
|
/run-e2e azure |
8cf2d26 to
2cce1ef
Compare
beb3c4d to
0680458
Compare
|
hello team, Could you please help me understand what’s wrong with my pull request? Semgrep reports: • Findings: 4 (2 blocking) However, I only interacted with 3 of these findings. 
The last one cannot be addressed or responded to. 
Thank you! |
clement-mesureux
left a comment
There was a problem hiding this comment.
/fp This is part of a test mock. As this is not being done during actual runtime, this should be acceptable here.
467d362 to
0680458
Compare
|
semgrepo is already okey too, just the context.TODO inlined |
365f7eb to
9109276
Compare
…ase insensitive Signed-off-by: Clément Mesureux <clement.mesureux@axa.fr>
9109276 to
193bcf3
Compare
|
Thank you, team. Everything looks good. I just integrated your suggestions and proceeded with the rebase and conflict resolution. |
|
/run-e2e azure |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new configuration option caseInsensitiveDemandsProcessing to the Azure Pipelines scaler to enable case-insensitive comparison of pipeline job demands. This addresses an issue where Azure DevOps ignores demands based on case sensitivity differences.
- Adds new boolean field
CaseInsensitiveDemandsProcessingto scaler metadata - Implements case-insensitive demand matching using
strings.EqualFoldwhen enabled - Includes comprehensive test coverage for both case-sensitive (default) and case-insensitive behavior
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/scalers/azure_pipelines_scaler.go | Adds new configuration field and implements case-insensitive demand matching logic |
| pkg/scalers/azure_pipelines_scaler_test.go | Adds test cases to verify case-sensitive default behavior and new case-insensitive functionality |
| CHANGELOG.md | Documents the new feature addition |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
|
/run-e2e azure |
…ase insensitive (kedacore#7112) Signed-off-by: Clément Mesureux <clement.mesureux@axa.fr> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
…ase insensitive (kedacore#7112) Signed-off-by: Clément Mesureux <clement.mesureux@axa.fr> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ase insensitive (kedacore#7112) Signed-off-by: Clément Mesureux <clement.mesureux@axa.fr> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
feat(azure_pipelines_scaler): add an option to enable demands to be case insensitive
Azure Devops is case insensitive, scaler is not
When you have an Azure DevOps job with demands written in uppercase, Azure Pipelines tends to ignore them if they are configured in lowercase, and vice versa.
Checklist
Fixes #7111
Relates to #