Solace Scaler: Enhancement add support for hostlist of Solace brokers#7089
Conversation
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
|
/run-e2e solace |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Solace scaler to support Solace Disaster Recovery (DR) by adding hostlist functionality for multiple Solace brokers operating in active-standby mode.
- Add support for comma-separated list of Solace broker URLs in
solaceSempBaseURL - Implement VPN state checking to determine which broker is active before querying queue metrics
- Add round-robin logic to try different brokers when one fails or is in standby mode
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/scalers/solace_scaler.go | Main implementation adding hostlist support, VPN state checking, and failover logic |
| pkg/scalers/solace_scaler_test.go | Remove unused imports and simplify test to focus on metadata parsing |
| CHANGELOG.md | Add changelog entry for the new Solace hostlist feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
|
/run-e2e solace |
Signed-off-by: dpochopsky <david.pochopsky@solace.com>
|
/run-e2e solace |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
|
/run-e2e solace |
…kedacore#7089) Signed-off-by: David Pochopsky <david.pochopsky@united.com> Signed-off-by: dpochopsky <david.pochopsky@solace.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
…kedacore#7089) Signed-off-by: David Pochopsky <david.pochopsky@united.com> Signed-off-by: dpochopsky <david.pochopsky@solace.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>
…kedacore#7089) Signed-off-by: David Pochopsky <david.pochopsky@united.com> Signed-off-by: dpochopsky <david.pochopsky@solace.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>
The purpose of this change is to support Solace Disaster Recovery (DR). Solace DR introduces an additional Solace Broker and operates in an active standby mode, so the scaler needs to query two different brokers with different endpoints, verify connectivity status as well as determine which of the brokers are active, once that is deteremined, the scaler operates as it did before.
Checklist
Fixes #7090
Relates to #
Here's the link to the documentation update PR: kedacore/keda-docs#1536