feat(influxdb): add support for InfluxDB v3 in influxdb scaler by jmickey · Pull Request #7001 · kedacore/keda

jmickey · 2025-08-21T01:20:18Z

Provide a description of what has been changed

Add support for InfluxDB v3 in InfluxDB scaler.
Update tests and e2e tests

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6981

Relates to kedacore/keda-docs#1615

github-actions · 2025-08-21T01:20:25Z

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

pkg/scalers/influxdb_scaler.go

go.mod

jmickey · 2025-08-21T17:32:20Z

Not sure why that test suddenly fails, can't reproduce locally either. 🤔

SpiritZhou · 2025-08-22T05:12:21Z

/run-e2e influxdb
Update: You can check the progress here

pkg/scalers/influxdb_scaler.go

zroubalik · 2025-08-26T09:09:26Z

/run-e2e influxdb
Update: You can check the progress here

jmickey · 2025-09-16T15:35:20Z

Hey folks, I'm back from being away for a few weeks and just wanted to check if there was any actions required on my end to get this over the line?

JorTurFer · 2025-09-18T17:21:22Z

this comment is left > https://github.com/kedacore/keda/pull/7001/files#r2355289311

Could you take a look? 🙏

jmickey · 2025-09-19T09:16:40Z

this comment is left > https://github.com/kedacore/keda/pull/7001/files#r2355289311

Could you take a look? 🙏

Thanks @JorTurFer, that should be sorted now!

rickbrouwer · 2025-09-19T09:44:17Z

/run-e2e influxdb
Update: You can check the progress here

Copilot

Pull Request Overview

This PR adds support for InfluxDB v3 to the existing InfluxDB scaler, extending its compatibility beyond v2. The implementation includes validation logic, new client handling for v3, and comprehensive test coverage.

Introduces InfluxDB v3 client integration using the InfluxCommunity/influxdb3-go package
Adds metadata validation for v3-specific requirements (database, metricKey, queryType)
Creates comprehensive e2e tests for v3 functionality with activation and scaling scenarios

Reviewed Changes

Copilot reviewed 6 out of 950 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/scalers/influxdb_scaler.go	Main implementation with v3 client support, validation, and query handling
pkg/scalers/influxdb_scaler_test.go	Unit tests covering v3 metadata validation and metric generation
tests/scalers/influxdb/influxdb_v3/influxdb_v3_test.go	Complete e2e test suite for v3 functionality
tests/scalers/influxdb/influxdb_v2/influxdb_v2_test.go	Package name fix and path correction
go.mod	Dependency updates including new influxdb3-go package
CHANGELOG.md	Documentation of the new feature

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

pkg/scalers/influxdb_scaler.go

pkg/scalers/influxdb_scaler_test.go

zroubalik · 2025-09-19T12:01:07Z

/run-e2e influxdb
Update: You can check the progress here

tests/scalers/influxdb/influxdb_v2/influxdb_v2_test.go

rickbrouwer · 2025-09-29T19:17:48Z

Hi @jmickey

i see there is still one remaining question from Jan and one merge conflict.

semgrep-app · 2025-09-30T12:59:03Z

Semgrep found 2 context-todo findings:

pkg/scaling/executor/scale_scaledobjects_test.go
- L522 - Triage
- L589 - Triage

Consider to use well-defined context

Semgrep found 1 no-direct-write-to-responsewriter finding:

pkg/scalers/azure_pipelines_scaler_test.go
- L448 - Triage

Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

Signed-off-by: Josh Michielsen <github@mickey.dev>

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Josh Michielsen <github@mickey.dev>

Signed-off-by: Josh Michielsen <github@mickey.dev>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Josh Michielsen <github@mickey.dev>

Signed-off-by: Josh Michielsen <github@mickey.dev>

jmickey · 2025-09-30T13:15:10Z

@rickbrouwer should be good to go now

wozniakjan · 2025-09-30T13:58:01Z

/run-e2e influxdb
Update: You can check the progress here

…ore#7001) * feat(influxdb): add support for InfluxDB v3 in influxdb scaler Signed-off-by: Josh Michielsen <github@mickey.dev> * chore(deps): move new indirect deps to existing require block Signed-off-by: Josh Michielsen <github@mickey.dev> * fix: add nil check to influxdbv3 client close Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Josh Michielsen <github@mickey.dev> * fix: use enum struct tag param to validate InfluxVersion field Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Josh Michielsen <github@mickey.dev> * refactor(influxdb): add deprecated authToken from triggerMetadata param Signed-off-by: Josh Michielsen <github@mickey.dev> * chore: regenerate scaler schemas Signed-off-by: Josh Michielsen <github@mickey.dev> * chore: reduce calls to strings.ToLower() Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Josh Michielsen <github@mickey.dev> * chore: remove dotenv loading in influxdb e2e tests Signed-off-by: Josh Michielsen <github@mickey.dev> --------- Signed-off-by: Josh Michielsen <github@mickey.dev> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

…ore#7001) * feat(influxdb): add support for InfluxDB v3 in influxdb scaler Signed-off-by: Josh Michielsen <github@mickey.dev> * chore(deps): move new indirect deps to existing require block Signed-off-by: Josh Michielsen <github@mickey.dev> * fix: add nil check to influxdbv3 client close Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Josh Michielsen <github@mickey.dev> * fix: use enum struct tag param to validate InfluxVersion field Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Josh Michielsen <github@mickey.dev> * refactor(influxdb): add deprecated authToken from triggerMetadata param Signed-off-by: Josh Michielsen <github@mickey.dev> * chore: regenerate scaler schemas Signed-off-by: Josh Michielsen <github@mickey.dev> * chore: reduce calls to strings.ToLower() Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Josh Michielsen <github@mickey.dev> * chore: remove dotenv loading in influxdb e2e tests Signed-off-by: Josh Michielsen <github@mickey.dev> --------- Signed-off-by: Josh Michielsen <github@mickey.dev> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jmickey force-pushed the feat/add-influxdbv3-support branch from 37a8139 to c20e792 Compare August 21, 2025 01:47

SpiritZhou reviewed Aug 21, 2025

View reviewed changes

pkg/scalers/influxdb_scaler.go Show resolved Hide resolved

zroubalik reviewed Aug 21, 2025

View reviewed changes

go.mod Outdated Show resolved Hide resolved

jmickey requested a review from a team as a code owner August 22, 2025 16:13

keda-automation requested a review from a team August 22, 2025 16:14

JorTurFer reviewed Aug 22, 2025

View reviewed changes

pkg/scalers/influxdb_scaler.go Outdated Show resolved Hide resolved

pkg/scalers/influxdb_scaler.go Outdated Show resolved Hide resolved

pkg/scalers/influxdb_scaler.go Outdated Show resolved Hide resolved

keda-automation requested a review from a team August 22, 2025 21:10

jmickey force-pushed the feat/add-influxdbv3-support branch 4 times, most recently from 57a177e to e17c427 Compare August 22, 2025 22:06

zroubalik mentioned this pull request Sep 18, 2025

Release: 2.18.0 #6853

Closed

22 tasks

jmickey force-pushed the feat/add-influxdbv3-support branch from 0d8795a to be1c3d9 Compare September 19, 2025 09:15

jmickey force-pushed the feat/add-influxdbv3-support branch from 04a733a to d744160 Compare September 19, 2025 09:27

zroubalik requested a review from Copilot September 19, 2025 11:29

Copilot AI reviewed Sep 19, 2025

View reviewed changes

pkg/scalers/influxdb_scaler.go Show resolved Hide resolved

pkg/scalers/influxdb_scaler.go Outdated Show resolved Hide resolved

pkg/scalers/influxdb_scaler_test.go Show resolved Hide resolved

zroubalik approved these changes Sep 19, 2025

View reviewed changes

jmickey requested review from JorTurFer and rickbrouwer September 23, 2025 12:27

rickbrouwer approved these changes Sep 23, 2025

View reviewed changes

wozniakjan reviewed Sep 24, 2025

View reviewed changes

tests/scalers/influxdb/influxdb_v2/influxdb_v2_test.go Outdated Show resolved Hide resolved

keda-automation requested review from a team September 30, 2025 12:42

jmickey force-pushed the feat/add-influxdbv3-support branch 2 times, most recently from aafec84 to 73bbc4b Compare September 30, 2025 12:57

keda-automation requested a review from arapulido September 30, 2025 12:57

jmickey and others added 7 commits September 30, 2025 14:09

feat(influxdb): add support for InfluxDB v3 in influxdb scaler

d9ebe0f

Signed-off-by: Josh Michielsen <github@mickey.dev>

chore(deps): move new indirect deps to existing require block

1033202

Signed-off-by: Josh Michielsen <github@mickey.dev>

fix: add nil check to influxdbv3 client close

9de8f3f

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Josh Michielsen <github@mickey.dev>

fix: use enum struct tag param to validate InfluxVersion field

430b7ff

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Josh Michielsen <github@mickey.dev>

refactor(influxdb): add deprecated authToken from triggerMetadata param

623b961

Signed-off-by: Josh Michielsen <github@mickey.dev>

chore: regenerate scaler schemas

e9fb8aa

Signed-off-by: Josh Michielsen <github@mickey.dev>

chore: reduce calls to strings.ToLower()

cd0d207

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Josh Michielsen <github@mickey.dev>

jmickey force-pushed the feat/add-influxdbv3-support branch from 73bbc4b to 942d1d9 Compare September 30, 2025 13:11

chore: remove dotenv loading in influxdb e2e tests

e9e6bed

Signed-off-by: Josh Michielsen <github@mickey.dev>

jmickey force-pushed the feat/add-influxdbv3-support branch from 942d1d9 to e9e6bed Compare September 30, 2025 13:13

wozniakjan approved these changes Sep 30, 2025

View reviewed changes

wozniakjan enabled auto-merge (squash) September 30, 2025 13:59

wozniakjan merged commit 3fef646 into kedacore:main Sep 30, 2025
24 checks passed

Conversation

jmickey commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

Uh oh!

Uh oh!

jmickey commented Aug 21, 2025

Uh oh!

SpiritZhou commented Aug 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zroubalik commented Aug 26, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmickey commented Sep 16, 2025

Uh oh!

JorTurFer commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmickey commented Sep 19, 2025

Uh oh!

rickbrouwer commented Sep 19, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zroubalik commented Sep 19, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rickbrouwer commented Sep 29, 2025

Uh oh!

semgrep-app bot commented Sep 30, 2025

Uh oh!

jmickey commented Sep 30, 2025

Uh oh!

wozniakjan commented Sep 30, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jmickey commented Aug 21, 2025 •

edited

Loading

SpiritZhou commented Aug 22, 2025 •

edited by github-actions bot

Loading

zroubalik commented Aug 26, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Sep 18, 2025 •

edited

Loading

rickbrouwer commented Sep 19, 2025 •

edited by github-actions bot

Loading

zroubalik commented Sep 19, 2025 •

edited by github-actions bot

Loading

wozniakjan commented Sep 30, 2025 •

edited by github-actions bot

Loading