Refactor huawei cloudeye scaler#6978
Conversation
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
JorTurFer
left a comment
There was a problem hiding this comment.
I've checked the parameters one by one and I don't see any typo 😄
|
/skip-e2e |
|
Hi @wozniakjan / @JorTurFer Can you add a deprecation announcement on GitHub Discussions I'm not allowed to do that yet. |
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
|
I've updated the role but I'm not sure if this permissions will be enough (I've added all permissions related with discussions, so I hope it so), have a try and I'll open it if you still can't |
Unfortunately, I don't get the option |
|
The it looks that it's not possible if the person doesn't have admin/maintainer permission explicitly set 😢 |
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: David Pochopsky <david.pochopsky@united.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Refactor the scaler to match the new metadata guidelines.
Good review required, because there is no e2e test for the Huawei Cloudeye scaler.
Because there is a deprecate announcement in it I will create a changelog item and the items according the deprecation policy.
Checklist
Relates to #5797
Docs: kedacore/keda-docs#1610