Skip to content

Aligns command structure across all deployments#6966

Merged
JorTurFer merged 3 commits intokedacore:mainfrom
ForestEckhardt:sync-config-logic
Aug 22, 2025
Merged

Aligns command structure across all deployments#6966
JorTurFer merged 3 commits intokedacore:mainfrom
ForestEckhardt:sync-config-logic

Conversation

@ForestEckhardt
Copy link
Contributor

@ForestEckhardt ForestEckhardt commented Aug 7, 2025

Currently the way the config is for the written metrics-apiserver is both out of sync with how the other two deployments are structured but it also produces a somewhat spurious start command. If you inspect the running process you see that the start command is the following:

/keda-adapter --secure-port=6443 --logtostderr=true --v=0 /usr/local/bin/keda-adapter --secure-port=6443 --logtostderr=true --stderrthreshold=ERROR --v=0 --client-ca-file=/certs/ca.crt --tls-cert-file=/certs/tls.crt --tls-private-key-file=/certs/tls.key --cert-dir=/certs

Checklist

@github-actions
Copy link

github-actions bot commented Aug 7, 2025

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

Signed-off-by: Forest Eckhardt <forest.eckhardt@docker.com>
@ForestEckhardt
Copy link
Contributor Author

Is there anything that I need to do to get some movement on this PR?

@zroubalik
Copy link
Member

zroubalik commented Aug 19, 2025

/run-e2e internal
Update: You can check the progress here

@ForestEckhardt
Copy link
Contributor Author

@zroubalik It appears that the runner timed out :(

@ForestEckhardt ForestEckhardt requested a review from a team as a code owner August 22, 2025 14:24
@keda-automation keda-automation requested a review from a team August 22, 2025 14:24
@JorTurFer
Copy link
Member

JorTurFer commented Aug 22, 2025

/run-e2e internal
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) August 22, 2025 15:36
@JorTurFer JorTurFer merged commit 2b9097b into kedacore:main Aug 22, 2025
24 checks passed
jmickey pushed a commit to jmickey/keda that referenced this pull request Aug 22, 2025
Signed-off-by: Forest Eckhardt <forest.eckhardt@docker.com>
dpochopsky pushed a commit to dpochopsky/keda that referenced this pull request Sep 12, 2025
Signed-off-by: Forest Eckhardt <forest.eckhardt@docker.com>
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
alt-dima pushed a commit to alt-dima/keda that referenced this pull request Dec 13, 2025
Signed-off-by: Forest Eckhardt <forest.eckhardt@docker.com>
Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025
Signed-off-by: Forest Eckhardt <forest.eckhardt@docker.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026
Signed-off-by: Forest Eckhardt <forest.eckhardt@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants