Merged
Conversation
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
…o treat this as immutable) Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
dttung2905
reviewed
Jul 15, 2025
Contributor
dttung2905
left a comment
There was a problem hiding this comment.
Thanks for working on this. Just one nit and we are good to go
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
Member
|
/run-e2e |
dttung2905
approved these changes
Jul 17, 2025
dpochopsky
pushed a commit
to dpochopsky/keda
that referenced
this pull request
Sep 12, 2025
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com> Signed-off-by: David Pochopsky <david.pochopsky@united.com>
tangobango5
pushed a commit
to tangobango5/keda
that referenced
this pull request
Dec 22, 2025
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
tangobango5
pushed a commit
to tangobango5/keda
that referenced
this pull request
Feb 13, 2026
Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a bunch of nitpicky typo changes when I was having a look at the
pkg/scalers/postgresql_scaler.goto understand how it works under the bonnet, saw a typo in a comment and though if there's one, there might be a few more.Checklist
Doesn't fix any issues.
(apologies for the mess of force pushes, these should now be signed accordingly)