(fix): Sumo Logic scaler throws errors when upstream returns empty result by mittalvaibhav1 · Pull Request #6906 · kedacore/keda

mittalvaibhav1 · 2025-07-14T12:08:04Z

Follows up on #6736

This PR fixes how we handle empty responses from the upstream API. Previously, an empty result was incorrectly treated as a non-aggregate query.

Changes -

✅ If the API call returns raw messages but no records, it's considered a non-aggregate query. Updated logic to check both message count and record count (Previously, it was only checking record count).
✅ If the API returns no messages and no records (i.e. truly no data), it now returns 0 instead of throwing an error.
⚙️ To address the rate-limiting issues noticed by @rickbrouwer, this PR makes the pollingInterval for the log search job configurable. Note: this is distinct from KEDA’s existing polling interval. Since Sumo Logic Search Job APIs work asynchronously and require us to Poll for results, this allows control over how often we poll in a single execution.
Introduces exponential backOff rate-limit handling with configureable max retries.

Docs PR - kedacore/keda-docs#1599

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

rickbrouwer · 2025-07-14T13:12:54Z

/run-e2e sumologic
Update: You can check the progress here

…ssages Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

…onfigureable Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

rickbrouwer · 2025-07-15T11:42:07Z

/run-e2e sumologic
Update: You can check the progress here

rickbrouwer · 2025-07-15T11:49:20Z

I'm running the e2e, at least to see if there are any errors in the e2e test.
A proper review will definitely be necessary later on so this PR is out of draft.

rickbrouwer · 2025-07-15T14:44:26Z

There is still an error:

***0***5-07-***5T***:***6:***0Z	ERROR	sumologic_scaler	error getting metrics from sumologic	***"type": "ScaledObject", "namespace": "sumologic-keda-test-ns", "name": "sumologic-keda-test-so", "error": "error response from server: DELETE https://api.sumologic.com/api/v***/search/jobs/0A***6F75***A0***D76*** ***\n  \"status\" : 4***9,\n  \"id\" : \"WECVO-9OUC***-UTI***V\",\n  \"code\" : \"rate.limit.exceeded\",\n  \"message\" : \"API rate limit for this user has been exceeded.\"\n*** 4***9 Too Many Requests"***

Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

rickbrouwer · 2025-07-15T19:18:07Z

/run-e2e sumologic
Update: You can check the progress here

rickbrouwer · 2025-07-16T07:17:13Z

Great! I don't see any errors in the log anymore.

Given that a low pollingInterval may introduce rate limit errors, the only question is whether this is acceptable, or whether rate limit handling is necessary. I seem to recall that some scalers do implement this.
I'm curious how you look at that.

mittalvaibhav1 · 2025-07-16T19:03:54Z

It's certainly a good to have but I'm not sure if it's necessary. Generally, customers ingest metrics at 30/60 second scrape intervals. Lower pollingIntervals might not be useful to them. Given the backend also stores data in 1min rollups https://help.sumologic.com/docs/metrics/introduction/#how-does-sumo-store-metrics , the data is less likely to be updated within a few seconds. Open to whatever we deem best for Keda ecosystem.

rickbrouwer · 2025-07-17T07:10:38Z

That's right, but customers can always be unpredictable with their settings ;)

I'm in two minds.
One, a simple mention in the documentation.
Or two, rate limit error handling
I think the github runner scaler also does something like that.

mittalvaibhav1 · 2025-07-17T13:56:06Z

I'll spend some time on this tomorrow. Thank you for the references!

Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com>

mittalvaibhav1 · 2025-07-22T18:48:43Z

How does 0635562 look like for rate-limit handling? @rickbrouwer

rickbrouwer · 2025-07-22T19:24:09Z

/run-e2e sumologic
Update: You can check the progress here

Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com>

pkg/scalers/sumologic/sumologic.go

Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

rickbrouwer · 2025-07-24T15:57:22Z

/run-e2e sumologic
Update: You can check the progress here

Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

CHANGELOG.md

Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Vaibhav Mittal <53215737+mittalvaibhav1@users.noreply.github.com>

rickbrouwer · 2025-07-24T19:10:41Z

/run-e2e sumologic
Update: You can check the progress here

rickbrouwer

Thanks!

rickbrouwer · 2025-07-25T07:26:50Z

/run-e2e sumologic
Update: You can check the progress here

…sult (kedacore#6906) * (fix): `sumologic scaler`: don't complain if query results in zero messages Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): `sumologic scaler`: Update tests and making polling interval configureable Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): Increase sumologic scaler e2e pollingInterval Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): Add rate-limiting handling Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com> * (fix): tuning e2e Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com> * (fix): semgrep happy Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): update changelog Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * PR comments - removing changelog entry Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Vaibhav Mittal <53215737+mittalvaibhav1@users.noreply.github.com> --------- Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com> Signed-off-by: Vaibhav Mittal <53215737+mittalvaibhav1@users.noreply.github.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: David Pochopsky <david.pochopsky@united.com>

…sult (kedacore#6906) * (fix): `sumologic scaler`: don't complain if query results in zero messages Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): `sumologic scaler`: Update tests and making polling interval configureable Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): Increase sumologic scaler e2e pollingInterval Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): Add rate-limiting handling Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com> * (fix): tuning e2e Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com> * (fix): semgrep happy Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): update changelog Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * PR comments - removing changelog entry Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Vaibhav Mittal <53215737+mittalvaibhav1@users.noreply.github.com> --------- Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com> Signed-off-by: Vaibhav Mittal <53215737+mittalvaibhav1@users.noreply.github.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

…sult (kedacore#6906) * (fix): `sumologic scaler`: don't complain if query results in zero messages Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): `sumologic scaler`: Update tests and making polling interval configureable Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): Increase sumologic scaler e2e pollingInterval Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): Add rate-limiting handling Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com> * (fix): tuning e2e Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com> * (fix): semgrep happy Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * (fix): update changelog Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> * PR comments - removing changelog entry Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Vaibhav Mittal <53215737+mittalvaibhav1@users.noreply.github.com> --------- Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com> Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com> Signed-off-by: Vaibhav Mittal <53215737+mittalvaibhav1@users.noreply.github.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com>

mittalvaibhavs mentioned this pull request Jul 14, 2025

(feat): Add Sumo Logic scaler #6736

Merged

7 tasks

mittalvaibhav1 force-pushed the main branch from 54d7257 to bcb9836 Compare July 14, 2025 20:19

(fix): sumologic scaler: don't complain if query results in zero me…

c56931c

…ssages Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

mittalvaibhav1 force-pushed the main branch from bcb9836 to c56931c Compare July 14, 2025 20:20

mittalvaibhav1 changed the title ~~(chore): don't complain if query results in zero messages~~ (fix): Sumo Logic scaler throws errors when upstream returns empty result Jul 14, 2025

(fix): sumologic scaler: Update tests and making polling interval c…

e8e7d61

…onfigureable Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

(fix): Increase sumologic scaler e2e pollingInterval

6c39736

Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

wozniakjan approved these changes Jul 16, 2025

View reviewed changes

(fix): Add rate-limiting handling

0635562

Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com>

(fix): tuning e2e

006a062

Signed-off-by: mittalvaibhavs <mittalvaibhavandroid@gmail.com>

semgrep-app bot reviewed Jul 24, 2025

View reviewed changes

pkg/scalers/sumologic/sumologic.go Show resolved Hide resolved

mittalvaibhav1 force-pushed the main branch from 9c5eb13 to dbbdf09 Compare July 24, 2025 15:36

(fix): semgrep happy

a907096

Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

mittalvaibhav1 force-pushed the main branch from dbbdf09 to a907096 Compare July 24, 2025 15:37

Merge remote-tracking branch 'upstream/main'

415cefe

Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

mittalvaibhav1 mentioned this pull request Jul 24, 2025

(sumologic): update scaler docs for recent fixes in sumologic scaler kedacore/keda-docs#1599

Merged

1 task

mittalvaibhav1 marked this pull request as ready for review July 24, 2025 17:04

mittalvaibhav1 force-pushed the main branch from 61035c1 to 352123d Compare July 24, 2025 17:05

(fix): update changelog

4a70e83

Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>

mittalvaibhav1 force-pushed the main branch from 352123d to 4a70e83 Compare July 24, 2025 18:51

rickbrouwer requested changes Jul 24, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

PR comments - removing changelog entry

2b88edd

Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Vaibhav Mittal <53215737+mittalvaibhav1@users.noreply.github.com>

mittalvaibhav1 requested a review from rickbrouwer July 24, 2025 19:01

rickbrouwer approved these changes Jul 25, 2025

View reviewed changes

rickbrouwer added the ok-to-merge This PR can be merged label Jul 25, 2025

wozniakjan merged commit 246dd2a into kedacore:main Jul 25, 2025
28 checks passed

Conversation

mittalvaibhav1 commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

rickbrouwer commented Jul 14, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Jul 15, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Jul 15, 2025

Uh oh!

rickbrouwer commented Jul 15, 2025

Uh oh!

rickbrouwer commented Jul 15, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Jul 16, 2025

Uh oh!

mittalvaibhav1 commented Jul 16, 2025

Uh oh!

rickbrouwer commented Jul 17, 2025

Uh oh!

mittalvaibhav1 commented Jul 17, 2025

Uh oh!

mittalvaibhav1 commented Jul 22, 2025

Uh oh!

rickbrouwer commented Jul 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rickbrouwer commented Jul 24, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rickbrouwer commented Jul 24, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer left a comment

Choose a reason for hiding this comment

Uh oh!

rickbrouwer commented Jul 25, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mittalvaibhav1 commented Jul 14, 2025 •

edited

Loading

rickbrouwer commented Jul 14, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 15, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 15, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 22, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 24, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 24, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 25, 2025 •

edited by github-actions bot

Loading