Add `fetchUnfinishedJobsOnly` property to Azure Pipelines scaler trigger metadata by wbpascal · Pull Request #6894 · kedacore/keda

wbpascal · 2025-07-08T14:24:07Z

Adds a new property fetchUnfinishedJobsOnly to the trigger metadata of the Azure Pipelines scaler that accepts a boolean value. If the value true is given, the query parameter completedRequestCount=0 is given when requesting the pipeline queue length. If the value is false, previous logic is applied because completedRequestCount cannot be used at the same time as the $top query parameter. By default, the value false is used to not break existing behavior.

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on (repo) (Add documentation for fetchUnfinishedJobsOnly trigger property in Azure Pipelines scaler keda-docs#1583)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6819

Relates to #6148

Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

semgrep-app · 2025-07-08T14:25:21Z

pkg/scalers/azure_pipelines_scaler_test.go

+		t.Run(testData.testName, func(t *testing.T) {
+			var apiStub = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+				w.WriteHeader(http.StatusOK)
+				_, _ = w.Write(buildLoadJSON())


Semgrep identified a blocking 🔴 issue in your code:
Detected directly writing or similar in 'http.ResponseWriter.write()'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package and render data using 'template.Execute()'.

To resolve this comment:

🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

/fp <comment> for false positive

/ar <comment> for acceptable risk

/other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by no-direct-write-to-responsewriter.

_{You can view more details about this finding in the Semgrep AppSec Platform.}

/fp This is part of a test mock. As this is not being done during actual runtime, this should be acceptable here.

This better represents the new API query parameter that is being used as it also returns jobs that are already in progress/running and not only pending jobs. Additionally, it is now allowed to specify `parent` and `fetchUnfinishedJobsOnly` at the same time. Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

…gned

Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

Copilot

Pull Request Overview

This PR adds a new fetchUnfinishedJobsOnly property to the Azure Pipelines scaler trigger metadata that allows filtering for only unfinished pipeline jobs. When set to true, it uses the completedRequestCount=0 query parameter instead of the existing $top parameter, which provides more targeted job filtering while maintaining compatibility with parent agent configurations.

Adds fetchUnfinishedJobsOnly boolean property with validation to prevent conflicts with existing parameters
Refactors URL generation logic into a separate method for better testability
Implements comprehensive test coverage for URL generation scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
pkg/scalers/azure_pipelines_scaler.go	Adds new metadata property, validation logic, and URL generation method
pkg/scalers/azure_pipelines_scaler_test.go	Adds test cases for parameter validation and URL generation scenarios
CHANGELOG.md	Documents the new feature addition

Comments suppressed due to low confidence (2)

pkg/scalers/azure_pipelines_scaler_test.go:465

The test should verify the specific error or use a more descriptive assertion. Simply calling t.Fail() without context makes debugging failures difficult.

			if err != nil {

pkg/scalers/azure_pipelines_scaler_test.go:470

The test should provide more descriptive failure messages. Consider using t.Errorf() to show expected vs actual values instead of just calling t.Fail().

			if queueURL != expectedURL {

pkg/scalers/azure_pipelines_scaler_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

pkg/scalers/azure_pipelines_scaler.go

JorTurFer · 2025-08-16T17:01:24Z

/run-e2e pipeline
Update: You can check the progress here

Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

zroubalik · 2025-08-26T09:29:45Z

/run-e2e pipeline
Update: You can check the progress here

…gned Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

wbpascal · 2025-08-27T04:26:47Z

Thank you very much for merging :)

…ger metadata (kedacore#6894) * Add fetchPendingJobsOnly to Azure Pipeline scaler Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Add additional validation for trigger metadata Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * test: add tests for new azure pipelines scaler functionality Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Update changelog Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Revert to old default value for jobsToFetch Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Rename new property to fetchUnfinishedJobsOnly This better represents the new API query parameter that is being used as it also returns jobs that are already in progress/running and not only pending jobs. Additionally, it is now allowed to specify `parent` and `fetchUnfinishedJobsOnly` at the same time. Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Update CHANGELOG.md with new property name Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Fix typo in test case name Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Document decision on why branches are not merged Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> --------- Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: David Pochopsky <david.pochopsky@united.com>

…ger metadata (kedacore#6894) * Add fetchPendingJobsOnly to Azure Pipeline scaler Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Add additional validation for trigger metadata Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * test: add tests for new azure pipelines scaler functionality Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Update changelog Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Revert to old default value for jobsToFetch Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Rename new property to fetchUnfinishedJobsOnly This better represents the new API query parameter that is being used as it also returns jobs that are already in progress/running and not only pending jobs. Additionally, it is now allowed to specify `parent` and `fetchUnfinishedJobsOnly` at the same time. Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Update CHANGELOG.md with new property name Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Fix typo in test case name Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Document decision on why branches are not merged Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> --------- Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>

…ger metadata (kedacore#6894) * Add fetchPendingJobsOnly to Azure Pipeline scaler Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Add additional validation for trigger metadata Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * test: add tests for new azure pipelines scaler functionality Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Update changelog Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Revert to old default value for jobsToFetch Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Rename new property to fetchUnfinishedJobsOnly This better represents the new API query parameter that is being used as it also returns jobs that are already in progress/running and not only pending jobs. Additionally, it is now allowed to specify `parent` and `fetchUnfinishedJobsOnly` at the same time. Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Update CHANGELOG.md with new property name Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Fix typo in test case name Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Document decision on why branches are not merged Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> --------- Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

…ger metadata (kedacore#6894) * Add fetchPendingJobsOnly to Azure Pipeline scaler Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Add additional validation for trigger metadata Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * test: add tests for new azure pipelines scaler functionality Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Update changelog Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Revert to old default value for jobsToFetch Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Rename new property to fetchUnfinishedJobsOnly This better represents the new API query parameter that is being used as it also returns jobs that are already in progress/running and not only pending jobs. Additionally, it is now allowed to specify `parent` and `fetchUnfinishedJobsOnly` at the same time. Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Update CHANGELOG.md with new property name Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Fix typo in test case name Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> * Document decision on why branches are not merged Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> --------- Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>

wbpascal added 5 commits July 8, 2025 16:06

Add fetchPendingJobsOnly to Azure Pipeline scaler

772948b

Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

Add additional validation for trigger metadata

90bcff3

Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

test: add tests for new azure pipelines scaler functionality

b220ee0

Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

Update changelog

1c19c79

Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

Revert to old default value for jobsToFetch

5e29e72

Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

semgrep-app bot reviewed Jul 8, 2025

View reviewed changes

wbpascal mentioned this pull request Jul 9, 2025

Add documentation for fetchUnfinishedJobsOnly trigger property in Azure Pipelines scaler kedacore/keda-docs#1583

Merged

1 task

wbpascal changed the title ~~Add fetchPendingJobsOnly property to Azure Pipelines scaler trigger metadata~~ Add fetchUnfinishedJobsOnly property to Azure Pipelines scaler trigger metadata Jul 9, 2025

Merge branch 'main' into feature/azurePipelinesFetchPendingJobsOnlySi…

b713ec2

…gned

wbpascal marked this pull request as ready for review July 9, 2025 06:43

Update CHANGELOG.md with new property name

677bfc3

Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

zroubalik requested a review from Copilot July 21, 2025 15:25

Copilot AI reviewed Jul 21, 2025

View reviewed changes

pkg/scalers/azure_pipelines_scaler_test.go Outdated Show resolved Hide resolved

Fix typo in test case name

12ef90a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

JorTurFer reviewed Aug 16, 2025

View reviewed changes

pkg/scalers/azure_pipelines_scaler.go Show resolved Hide resolved

Document decision on why branches are not merged

8713390

Signed-off-by: Pascal Wiedenbeck <pascalw98@gmail.com>

wbpascal force-pushed the feature/azurePipelinesFetchPendingJobsOnlySigned branch from 67f1339 to 8713390 Compare August 19, 2025 15:38

JorTurFer approved these changes Aug 20, 2025

View reviewed changes

Merge branch 'main' into feature/azurePipelinesFetchPendingJobsOnlySi…

ae8b495

…gned Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

zroubalik requested a review from a team as a code owner August 26, 2025 09:31

keda-automation requested a review from a team August 26, 2025 09:32

zroubalik enabled auto-merge (squash) August 26, 2025 09:32

zroubalik approved these changes Aug 26, 2025

View reviewed changes

zroubalik disabled auto-merge August 26, 2025 11:09

zroubalik merged commit f553e4a into kedacore:main Aug 26, 2025
21 of 24 checks passed

wbpascal deleted the feature/azurePipelinesFetchPendingJobsOnlySigned branch August 27, 2025 04:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `fetchUnfinishedJobsOnly` property to Azure Pipelines scaler trigger metadata#6894

Add `fetchUnfinishedJobsOnly` property to Azure Pipelines scaler trigger metadata#6894
zroubalik merged 11 commits intokedacore:mainfrom
wbpascal:feature/azurePipelinesFetchPendingJobsOnlySigned

wbpascal commented Jul 8, 2025 •

edited

Loading

Uh oh!

semgrep-app bot Jul 8, 2025

Uh oh!

wbpascal Jul 9, 2025

Uh oh!

JorTurFer Aug 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented Aug 16, 2025 •

edited by github-actions bot

Loading

Uh oh!

zroubalik commented Aug 26, 2025 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

wbpascal commented Aug 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

wbpascal commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

semgrep-app bot Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

wbpascal Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

JorTurFer Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented Aug 16, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zroubalik commented Aug 26, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

wbpascal commented Aug 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wbpascal commented Jul 8, 2025 •

edited

Loading

JorTurFer commented Aug 16, 2025 •

edited by github-actions bot

Loading

zroubalik commented Aug 26, 2025 •

edited by github-actions bot

Loading