Skip to content

fix: fixed cron scaler to return zero metric value by default#6888

Merged
wozniakjan merged 3 commits intokedacore:mainfrom
frauniki:cron-zero-scale
Aug 17, 2025
Merged

fix: fixed cron scaler to return zero metric value by default#6888
wozniakjan merged 3 commits intokedacore:mainfrom
frauniki:cron-zero-scale

Conversation

@frauniki
Copy link
Contributor

@frauniki frauniki commented Jul 7, 2025 •
edited
Loading

Fixed cron scaler to return zero metric value by default.

Checklist

Fixes #6886

@frauniki frauniki force-pushed the cron-zero-scale branch 4 times, most recently from 9049346 to 70a229a Compare July 7, 2025 05:19
@frauniki frauniki changed the title fix: cron_scaler returns zero metric value by default fix: fixed cron scaler to return zero metric value by default Jul 7, 2025
@rickbrouwer
Copy link
Member

rickbrouwer commented Jul 7, 2025

Hi!

The autogenerated deepcopy function are not needed for this change I think. Could you remove them?

@frauniki frauniki force-pushed the cron-zero-scale branch 4 times, most recently from 38f4f61 to f11c1f0 Compare July 8, 2025 03:21
@frauniki
Copy link
Contributor Author

frauniki commented Jul 8, 2025

Hi!

The autogenerated deepcopy function are not needed for this change I think. Could you remove them?

fixed

@frauniki frauniki force-pushed the cron-zero-scale branch 2 times, most recently from b5ed076 to fdcd207 Compare July 8, 2025 03:27
@rickbrouwer
Copy link
Member

rickbrouwer commented Jul 8, 2025 •
edited by github-actions bot
Loading

/run-e2e cron
Update: You can check the progress here

rickbrouwer
rickbrouwer reviewed Jul 8, 2025
View reviewed changes
@frauniki frauniki force-pushed the cron-zero-scale branch 2 times, most recently from 1639848 to 8e1af63 Compare July 8, 2025 08:17
@frauniki frauniki requested a review from rickbrouwer July 8, 2025 08:18
rickbrouwer
rickbrouwer reviewed Jul 8, 2025
View reviewed changes
@frauniki
fix: cron_scaler returns zero metric value by default
6bc2279 
Signed-off-by: frauniki <frauniki@sinoa.jp>
@rickbrouwer
Copy link
Member

rickbrouwer commented Jul 8, 2025 •
edited by github-actions bot
Loading

/run-e2e cron
Update: You can check the progress here

rickbrouwer
rickbrouwer approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@rickbrouwer rickbrouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@SpiritZhou
Copy link
Contributor

SpiritZhou commented Jul 10, 2025

LGTM!

@rickbrouwer rickbrouwer added the ok-to-merge This PR can be merged label Jul 23, 2025
@rickbrouwer
Copy link
Member

rickbrouwer commented Jul 23, 2025 •
edited by github-actions bot
Loading

/run-e2e cron
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@wozniakjan wozniakjan enabled auto-merge (squash) August 7, 2025 12:14
@JorTurFer
Merge branch 'main' into cron-zero-scale
c20ad6b 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member

JorTurFer commented Aug 17, 2025

/skip-e2e

@JorTurFer
fix changelog error
bf053d9 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@wozniakjan wozniakjan merged commit c2f562f into kedacore:main Aug 17, 2025
23 checks passed
jmickey pushed a commit to jmickey/keda that referenced this pull request Aug 22, 2025
@frauniki @jmickey
fix: cron_scaler returns zero metric value by default (kedacore#6888)
6a01901 
Signed-off-by: frauniki <frauniki@sinoa.jp>
dpochopsky pushed a commit to dpochopsky/keda that referenced this pull request Sep 12, 2025
@frauniki @dpochopsky
fix: cron_scaler returns zero metric value by default (kedacore#6888)
4c355bb 
Signed-off-by: frauniki <frauniki@sinoa.jp>
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
@rickbrouwer rickbrouwer mentioned this pull request Oct 25, 2025
Closed
alt-dima pushed a commit to alt-dima/keda that referenced this pull request Dec 13, 2025
@frauniki @alt-dima
fix: cron_scaler returns zero metric value by default (kedacore#6888)
8605afb 
Signed-off-by: frauniki <frauniki@sinoa.jp>
Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025
@frauniki
fix: cron_scaler returns zero metric value by default (kedacore#6888)
7296189 
Signed-off-by: frauniki <frauniki@sinoa.jp>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026
@frauniki @tangobango5
fix: cron_scaler returns zero metric value by default (kedacore#6888)
9abc1af 
Signed-off-by: frauniki <frauniki@sinoa.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

@rickbrouwer rickbrouwer rickbrouwer approved these changes

+1 more reviewer

@SpiritZhou SpiritZhou SpiritZhou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-merge This PR can be merged skip-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cron_scaler always reports 1 when inactive, preventing zero scaling with scalingModifiers

6 participants

@frauniki @rickbrouwer @SpiritZhou @JorTurFer @wozniakjan @keda-automation