Skip to content

refactor gcp pubsub scaler#6866

Merged
JorTurFer merged 8 commits intokedacore:mainfrom
stevencjy:gcp-pubsub-scaler-typed-config
Aug 7, 2025
Merged

refactor gcp pubsub scaler#6866
JorTurFer merged 8 commits intokedacore:mainfrom
stevencjy:gcp-pubsub-scaler-typed-config

Conversation

@stevencjy
Copy link
Contributor

refactor gcp pubsub scaler to use typed config

Checklist

Relates to #5797

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
@stevencjy stevencjy requested a review from a team as a code owner June 25, 2025 05:53
@stevencjy stevencjy marked this pull request as draft June 25, 2025 06:20
@stevencjy stevencjy marked this pull request as ready for review June 25, 2025 06:24
Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
@stevencjy stevencjy force-pushed the gcp-pubsub-scaler-typed-config branch from a658fa3 to 6054a48 Compare July 9, 2025 08:00
@rickbrouwer
Copy link
Member

rickbrouwer commented Jul 9, 2025

/run-e2e gcp
Update: You can check the progress here

Copy link
Member

@rickbrouwer rickbrouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@rickbrouwer rickbrouwer added the ok-to-merge This PR can be merged label Jul 23, 2025
@rickbrouwer
Copy link
Member

rickbrouwer commented Jul 23, 2025

/run-e2e gcp
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 4b5c62e into kedacore:main Aug 7, 2025
27 checks passed
dpochopsky pushed a commit to dpochopsky/keda that referenced this pull request Sep 12, 2025
* Refactor gcp pubsub scaler, typed config

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Minor fix to test

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Minor fix to default value

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Resolve comments

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Force default mod when subscriptionsize is present

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Add deprecate message in changelog. Scaler to use time duration reflect

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

---------

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
alt-dima pushed a commit to alt-dima/keda that referenced this pull request Dec 13, 2025
* Refactor gcp pubsub scaler, typed config

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Minor fix to test

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Minor fix to default value

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Resolve comments

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Force default mod when subscriptionsize is present

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Add deprecate message in changelog. Scaler to use time duration reflect

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

---------

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025
* Refactor gcp pubsub scaler, typed config

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Minor fix to test

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Minor fix to default value

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Resolve comments

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Force default mod when subscriptionsize is present

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Add deprecate message in changelog. Scaler to use time duration reflect

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

---------

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026
* Refactor gcp pubsub scaler, typed config

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Minor fix to test

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Minor fix to default value

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Resolve comments

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Force default mod when subscriptionsize is present

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

* Add deprecate message in changelog. Scaler to use time duration reflect

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>

---------

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-merge This PR can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants