Skip to content

refactor github runner scaler#6834

Merged
zroubalik merged 4 commits intokedacore:mainfrom
stevencjy:github-runner-scaler-typed-config
Jul 21, 2025
Merged

refactor github runner scaler#6834
zroubalik merged 4 commits intokedacore:mainfrom
stevencjy:github-runner-scaler-typed-config

Conversation

@stevencjy
Copy link
Contributor

@stevencjy stevencjy commented Jun 11, 2025 •
edited
Loading

Provide a description of what has been changed

Checklist

Relates to #5797

@stevencjy stevencjy requested a review from a team as a code owner June 11, 2025 05:56
rickbrouwer
rickbrouwer reviewed Jun 11, 2025
View reviewed changes
@rickbrouwer
Copy link
Member

rickbrouwer commented Jun 15, 2025 •
edited by github-actions bot
Loading

/run-e2e github*
Update: You can check the progress here

rickbrouwer
rickbrouwer reviewed Jun 16, 2025
View reviewed changes
wozniakjan
wozniakjan approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

(+1 to mentioned enums improvement)

@stevencjy
Copy link
Contributor Author

stevencjy commented Jun 18, 2025

hi, I've pushed a fix.

would like to request another /run-e2e github*

thanks

@rickbrouwer
Copy link
Member

rickbrouwer commented Jun 18, 2025 •
edited
Loading

What about using a const githubDefaultPerPage = 30 and

if len(repos) < githubDefaultPerPage {
            break
}

And is it an idea to merge ORG and ENT since they use the same url?

switch s.metadata.RunnerScope {
case ORG, ENT:
	// Both use the same endpoint format
	url = fmt.Sprintf("%s/orgs/%s/repos?page=%s", s.metadata.GithubAPIURL, s.metadata.Owner, strconv.Itoa(page))
case REPO:
	url = fmt.Sprintf("%s/users/%s/repos?page=%s", s.metadata.GithubAPIURL, s.metadata.Owner, strconv.Itoa(page))
default:
	return nil, fmt.Errorf("runnerScope %s not supported", s.metadata.RunnerScope)

@stevencjy
Copy link
Contributor Author

stevencjy commented Jun 18, 2025

nice catch, pushed a fix

What about using a const githubDefaultPerPage = 30 and

if len(repos) < githubDefaultPerPage {
            break
}

And is it an idea to merge ORG and ENT since they use the same url?

switch s.metadata.RunnerScope {
case ORG, ENT:
	// Both use the same endpoint format
	url = fmt.Sprintf("%s/orgs/%s/repos?page=%s", s.metadata.GithubAPIURL, s.metadata.Owner, strconv.Itoa(page))
case REPO:
	url = fmt.Sprintf("%s/users/%s/repos?page=%s", s.metadata.GithubAPIURL, s.metadata.Owner, strconv.Itoa(page))
default:
	return nil, fmt.Errorf("runnerScope %s not supported", s.metadata.RunnerScope)

This was referenced Jun 18, 2025
Merged
Closed
@dttung2905 dttung2905 mentioned this pull request Jun 30, 2025
Open
58 tasks
stevencjy added 4 commits July 7, 2025 20:42
@stevencjy @wozniakjan
Update commit with sign. Add typedconfig and fix github runner test
954e5a8 
Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
@stevencjy @wozniakjan
Remove optional from TargetWorkflowQueueLength metadata as default is…
89b92e9 
… present. Address comment

Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
@stevencjy @wozniakjan
Add runnerscope enum and test
484532c 
Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
@stevencjy @wozniakjan
Address comment
e92e05c 
Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
@wozniakjan wozniakjan force-pushed the github-runner-scaler-typed-config branch from f1a1070 to e92e05c Compare July 7, 2025 18:42
@rickbrouwer
Copy link
Member

rickbrouwer commented Jul 9, 2025 •
edited by github-actions bot
Loading

/run-e2e github*
Update: You can check the progress here

rickbrouwer
rickbrouwer approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@rickbrouwer rickbrouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙌🏼

@zroubalik zroubalik merged commit 2034dbf into kedacore:main Jul 21, 2025
25 checks passed
@stevencjy stevencjy deleted the github-runner-scaler-typed-config branch July 22, 2025 03:30
dpochopsky pushed a commit to dpochopsky/keda that referenced this pull request Sep 12, 2025
@stevencjy @dpochopsky
refactor github runner scaler (kedacore#6834)
b8ac28b 
Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
Signed-off-by: David Pochopsky <david.pochopsky@united.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025
@stevencjy
refactor github runner scaler (kedacore#6834)
13ab445 
Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026
@stevencjy @tangobango5
refactor github runner scaler (kedacore#6834)
9ba6396 
Signed-off-by: Steven Chau <stevenchau1998@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zroubalik zroubalik zroubalik approved these changes

@wozniakjan wozniakjan wozniakjan approved these changes

@rickbrouwer rickbrouwer rickbrouwer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stevencjy @rickbrouwer @zroubalik @wozniakjan